public inbox for kawa@sourceware.org
 help / color / mirror / Atom feed
* ant help needed
@ 2015-08-01  6:41 Per Bothner
  2015-08-10 19:01 ` [PATCH] PreProcess fix (was Re: ant help needed) Jamison Hope
  0 siblings, 1 reply; 3+ messages in thread
From: Per Bothner @ 2015-08-01  6:41 UTC (permalink / raw)
  To: Kawa mailing list

The various XxxVector.java classes in gnu/lists are now generated
from the file gnu/lists/PrimVector.template, using the  program
gnu/kawa/util/PreProcess.java.  Currently, the source files (such
as FVector.java and U32Vector.java) are checked in, and generated
as needed using Makefile rules.

The build should still work using Ant, because the generated
files are in the repository.  However, I'd like to remove these
files, but first we need to update Ant to generate them.
Most of the work is handled by PreProcess, which is already called by
Ant's build.xml (to handle converting between between Java7/Java8/etc).
So it's just a matter of calling PreProcess with the right arguments,
which is fairly simple.

I also just noticed that Ant reports a bunch of:
   java.io.FileNotFoundException: JAVA5  (No such file or directory)
I won't have time to look into this right now, but I'll do so
on Sunday if no-one beats me to it.
-- 
	--Per Bothner
per@bothner.com   http://per.bothner.com/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] PreProcess fix (was Re: ant help needed)
  2015-08-01  6:41 ant help needed Per Bothner
@ 2015-08-10 19:01 ` Jamison Hope
  2015-08-13 18:05   ` Per Bothner
  0 siblings, 1 reply; 3+ messages in thread
From: Jamison Hope @ 2015-08-10 19:01 UTC (permalink / raw)
  To: Kawa mailing list

[-- Attachment #1: Type: text/plain, Size: 400 bytes --]

On Aug 1, 2015, at 2:41 AM, Per Bothner <per@bothner.com> wrote:

> I also just noticed that Ant reports a bunch of:
>  java.io.FileNotFoundException: JAVA5  (No such file or directory)

This was due to a typo in PreProcess.java, it was scanning the string for charAt(0) instead of the separator.  The attached patch should fix it.


--
Jamison Hope
The PTR Group
www.theptrgroup.com



[-- Attachment #2: PreProcess-fix-FileNotFound.patch --]
[-- Type: application/octet-stream, Size: 1125 bytes --]

Index: gnu/kawa/util/ChangeLog
===================================================================
--- gnu/kawa/util/ChangeLog	(revision 8581)
+++ gnu/kawa/util/ChangeLog	(working copy)
@@ -1,3 +1,8 @@
+2015-08-10  Jamison Hope  <jrh@theptrgroup.com>
+
+	* PreProcess.java (handleArg): Fix typo: repeatedly search for
+	separator character, not charAt(0).
+
 2015-07-31  Per Bothner  <per@bothner.com>
 
 	* PreProcess.java: Bunch of changes to support pre-processing
Index: gnu/kawa/util/PreProcess.java
===================================================================
--- gnu/kawa/util/PreProcess.java	(revision 8581)
+++ gnu/kawa/util/PreProcess.java	(working copy)
@@ -470,7 +470,7 @@
                     char sep = feat0 == '/' || feat0 == ';' ? feat0 : ' ';
                     int start = 0;
                     while (start >= 0) {
-                        int ind = features.indexOf(feat0, start);
+                        int ind = features.indexOf(sep, start);
                         String farg;
                         if (ind >= 0) {
                             farg = features.substring(start, ind);

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] PreProcess fix (was Re: ant help needed)
  2015-08-10 19:01 ` [PATCH] PreProcess fix (was Re: ant help needed) Jamison Hope
@ 2015-08-13 18:05   ` Per Bothner
  0 siblings, 0 replies; 3+ messages in thread
From: Per Bothner @ 2015-08-13 18:05 UTC (permalink / raw)
  To: kawa



On 08/10/2015 12:01 PM, Jamison Hope wrote:
> On Aug 1, 2015, at 2:41 AM, Per Bothner <per@bothner.com> wrote:
>
>> I also just noticed that Ant reports a bunch of:
>> java.io.FileNotFoundException: JAVA5  (No such file or directory)
>
> This was due to a typo in PreProcess.java, it was scanning the string
> for charAt(0) instead of the separator.  The attached patch should
> fix it.

Oops. Checked in.  Thanks!
-- 
	--Per Bothner
per@bothner.com   http://per.bothner.com/

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-08-13 18:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-01  6:41 ant help needed Per Bothner
2015-08-10 19:01 ` [PATCH] PreProcess fix (was Re: ant help needed) Jamison Hope
2015-08-13 18:05   ` Per Bothner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).