public inbox for kawa@sourceware.org
 help / color / mirror / Atom feed
* -w option and JEmacs working again
@ 2016-03-11  7:37 Per Bothner
  2016-03-11 18:34 ` Debabrata Pani
  0 siblings, 1 reply; 6+ messages in thread
From: Per Bothner @ 2016-03-11  7:37 UTC (permalink / raw)
  To: Kawa mailing list

The -w option (to create a new Swing-based REPL window) was broken
for a while, but should now be working again.

Related changes also broke JEmacs, which should now also work again.
(Well, at least better than it was ...)
-- 
	--Per Bothner
per@bothner.com   http://per.bothner.com/

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: -w option and JEmacs working again
  2016-03-11  7:37 -w option and JEmacs working again Per Bothner
@ 2016-03-11 18:34 ` Debabrata Pani
  2016-03-11 18:43   ` Per Bothner
  0 siblings, 1 reply; 6+ messages in thread
From: Debabrata Pani @ 2016-03-11 18:34 UTC (permalink / raw)
  To: Per Bothner; +Cc: Kawa mailing list

Hi Per,

Excuse me for any obvious mistake .

I tried refreshing the kawa project and the top-level changelog shows:

2016-02-14  Per Bothner  <per@bothner.com>

    Add support for JLine2 as a readline alternative.
    * configure.ac" New --with-jline2 flag.
    (WITH_JLINE2_ARG. WITH_JLINE2): New argument and conditional.
    * config.classpath: Adjust classpath based on --with-jline2 flag.
    * Makefile.am (dist-kawa-@VERSION@.jar): Build jline2 support,
    without requiring it.

2016-01-26  Per Bothner  <per@bothner.com>

    * configure.ac: Fix case when --with-java-source is defaulted.


But after doing: ./configure and make

I don't see

java -cp kawa-2.1.1.jar kawa.repl -w

bringing up the swing-based repl .

This is on
MAC-OSX-10.9.5
java -version
java version "1.7.0_60"
Java(TM) SE Runtime Environment (build 1.7.0_60-b19)
Java HotSpot(TM) 64-Bit Server VM (build 24.60-b09, mixed mode)


Is the code not up-to-date ? Or am I missing some obvious
configuration during  "configure" ?

Regards,
Debabrata

On Fri, Mar 11, 2016 at 1:07 PM, Per Bothner <per@bothner.com> wrote:
> The -w option (to create a new Swing-based REPL window) was broken
> for a while, but should now be working again.
>
> Related changes also broke JEmacs, which should now also work again.
> (Well, at least better than it was ...)
> --
>         --Per Bothner
> per@bothner.com   http://per.bothner.com/

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: -w option and JEmacs working again
  2016-03-11 18:34 ` Debabrata Pani
@ 2016-03-11 18:43   ` Per Bothner
  2016-03-11 19:06     ` Jamison Hope
  0 siblings, 1 reply; 6+ messages in thread
From: Per Bothner @ 2016-03-11 18:43 UTC (permalink / raw)
  To: Debabrata Pani; +Cc: Kawa mailing list



On 03/11/2016 10:34 AM, Debabrata Pani wrote:

> I tried refreshing the kawa project and the top-level changelog shows:
>
> 2016-02-14  Per Bothner  <per@bothner.com>
>
>      Add support for JLine2 as a readline alternative.

That is correct, but I didn't change the top-level Makefile.  The related fix
should be available if gnu/lists/ChangeLog starts with:

2016-03-10  Per Bothner  <per@bothner.com>

         Major re-write for more general array support.

> But after doing: ./configure and make
>
> I don't see
>
> java -cp kawa-2.1.1.jar kawa.repl -w
>
> bringing up the swing-based repl .
>
> This is on
> MAC-OSX-10.9.5
> java -version
> java version "1.7.0_60"
> Java(TM) SE Runtime Environment (build 1.7.0_60-b19)
> Java HotSpot(TM) 64-Bit Server VM (build 24.60-b09, mixed mode)

It works for me. However, I haven't tested it on MacOS.

> Is the code not up-to-date ? Or am I missing some obvious
> configuration during  "configure" ?

No special configure option needed - I just verified that.

Could someone else try on MacOS?
-- 
	--Per Bothner
per@bothner.com   http://per.bothner.com/

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: -w option and JEmacs working again
  2016-03-11 18:43   ` Per Bothner
@ 2016-03-11 19:06     ` Jamison Hope
  2016-03-11 19:23       ` Per Bothner
  2016-03-11 20:37       ` Per Bothner
  0 siblings, 2 replies; 6+ messages in thread
From: Jamison Hope @ 2016-03-11 19:06 UTC (permalink / raw)
  To: kawa list


On Mar 11, 2016, at 1:43 PM, Per Bothner <per@bothner.com> wrote:

> Could someone else try on MacOS?

It happens for me, too.  I believe the issue is that on the Mac OS X
port of the Java SE runtime, the AWT Event Dispatch Thread is not
the process's "main" thread, and so GuiConsole#setVisible() is
getting called off of the EDT.

Technically, I think all of the Swing instantiation is supposed to happen
on the EDT, but setVisible() seems to be the only one that *really*
matters.

This change to GuiConsole#init() fixes it for me:

> Index: kawa/GuiConsole.java
> ===================================================================
> --- kawa/GuiConsole.java	(revision 8722)
> +++ kawa/GuiConsole.java	(working copy)
> @@ -59,7 +59,7 @@
>      //pack();
>      setLocation(100 * window_number, 50 * window_number);
>      setSize(700,500);
> -    setVisible(true);
> +    EventQueue.invokeLater(new Runnable() { public void run() { setVisible(true); }});
>    }
>  
>    public GuiConsole(Language language, Environment penvironment, boolean shared)


Once it's up and running, though, I get an exception every time I hit backspace:

Exception in thread "AWT-EventQueue-0" java.lang.UnsupportedOperationException: gnu.lists.CharBuffer does not implement removePosRange
	at gnu.lists.AbstractSequence.unsupportedException(AbstractSequence.java:207)
	at gnu.lists.AbstractSequence.unsupported(AbstractSequence.java:201)
	at gnu.lists.AbstractSequence.removePosRange(AbstractSequence.java:424)
	at gnu.lists.AbstractSequence.removePos(AbstractSequence.java:409)
	at gnu.lists.CharBuffer.delete(CharBuffer.java:39)
	at gnu.kawa.swingviews.SwingContent.remove(SwingContent.java:70)
	[...]

--
Jamison Hope
The PTR Group
www.theptrgroup.com



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: -w option and JEmacs working again
  2016-03-11 19:06     ` Jamison Hope
@ 2016-03-11 19:23       ` Per Bothner
  2016-03-11 20:37       ` Per Bothner
  1 sibling, 0 replies; 6+ messages in thread
From: Per Bothner @ 2016-03-11 19:23 UTC (permalink / raw)
  To: Jamison Hope, kawa list



On 03/11/2016 11:05 AM, Jamison Hope wrote:

> Once it's up and running, though, I get an exception every time I hit backspace:
>
> Exception in thread "AWT-EventQueue-0" java.lang.UnsupportedOperationException: gnu.lists.CharBuffer does not implement removePosRange
> 	at gnu.lists.AbstractSequence.unsupportedException(AbstractSequence.java:207)
> 	at gnu.lists.AbstractSequence.unsupported(AbstractSequence.java:201)
> 	at gnu.lists.AbstractSequence.removePosRange(AbstractSequence.java:424)
> 	at gnu.lists.AbstractSequence.removePos(AbstractSequence.java:409)
> 	at gnu.lists.CharBuffer.delete(CharBuffer.java:39)
> 	at gnu.kawa.swingviews.SwingContent.remove(SwingContent.java:70)
> 	[...]

I'm getting the same.  I'll work on it shortly.

For what it's worth: I will probably focus more on making it easier to use
DomTerm for the REPL - but we still want the old Swing REPL to work too!
-- 
	--Per Bothner
per@bothner.com   http://per.bothner.com/

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: -w option and JEmacs working again
  2016-03-11 19:06     ` Jamison Hope
  2016-03-11 19:23       ` Per Bothner
@ 2016-03-11 20:37       ` Per Bothner
  1 sibling, 0 replies; 6+ messages in thread
From: Per Bothner @ 2016-03-11 20:37 UTC (permalink / raw)
  To: Jamison Hope, kawa list

On 03/11/2016 11:05 AM, Jamison Hope wrote:
> This change to GuiConsole#init() fixes it for me:
>
>> Index: kawa/GuiConsole.java
>> ===================================================================
>> --- kawa/GuiConsole.java	(revision 8722)
>> +++ kawa/GuiConsole.java	(working copy)
>> -    setVisible(true);
>> +    EventQueue.invokeLater(new Runnable() { public void run() { setVisible(true); }});

Thanks.  I checked this in (with an extra line-break).

> Once it's up and running, though, I get an exception every time I hit backspace:
>
> Exception in thread "AWT-EventQueue-0" java.lang.UnsupportedOperationException: gnu.lists.CharBuffer does not implement removePosRange
> 	at gnu.lists.AbstractSequence.unsupportedException(AbstractSequence.java:207)
> 	at gnu.lists.AbstractSequence.unsupported(AbstractSequence.java:201)
> 	at gnu.lists.AbstractSequence.removePosRange(AbstractSequence.java:424)
> 	at gnu.lists.AbstractSequence.removePos(AbstractSequence.java:409)
> 	at gnu.lists.CharBuffer.delete(CharBuffer.java:39)

I checked in a fix for this.
-- 
	--Per Bothner
per@bothner.com   http://per.bothner.com/

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-03-11 20:37 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-11  7:37 -w option and JEmacs working again Per Bothner
2016-03-11 18:34 ` Debabrata Pani
2016-03-11 18:43   ` Per Bothner
2016-03-11 19:06     ` Jamison Hope
2016-03-11 19:23       ` Per Bothner
2016-03-11 20:37       ` Per Bothner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).