public inbox for kawa@sourceware.org
 help / color / mirror / Atom feed
From: Jamison Hope <jrh@theptrgroup.com>
To: kawa list <kawa@sourceware.org>
Subject: build.xml patch for building under RHEL6
Date: Wed, 20 Jul 2016 17:18:00 -0000	[thread overview]
Message-ID: <5DF8F292-6E3C-4A18-BBCC-5F5C77FB5517@theptrgroup.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 484 bytes --]

It would appear that <echo file="a/b/c"> isn't guaranteed to work if the
subdirectories "a" and "a/b" don't exist yet.  In particular, when Kawa
is checked out under RHEL 6, building via Ant 1.7.1 and Java 1.6.0_24
(ugh, don't ask) fails with a FileNotFoundException attempting to open
META-INF/services/javax.script.ScriptEngineFactory.

The fix is to <mkdir dir="META-INF/services"/> before the <echo>, as
in the attached patch.

--
Jamison Hope
The PTR Group
www.theptrgroup.com



[-- Attachment #2: build-xml-j6.patch --]
[-- Type: application/octet-stream, Size: 1261 bytes --]

Index: build.xml
===================================================================
--- build.xml	(revision 8883)
+++ build.xml	(working copy)
@@ -855,11 +855,13 @@
   </target>
 
   <target name="script-factory-scheme" if="${-needs-scripting-inf}">
+    <mkdir dir="META-INF/services"/>
     <echo message="kawa.standard.SchemeScriptEngineFactory #Scheme&#xA;"
           append="true"
           file="META-INF/services/javax.script.ScriptEngineFactory"/>
   </target>
   <target name="script-factory-xquery" if="${-needs-scripting-inf-xquery}">
+    <mkdir dir="META-INF/services"/>
     <echo message="gnu.xquery.lang.XQueryScriptEngineFactory #XQuery&#xA;"
           append="true"
           file="META-INF/services/javax.script.ScriptEngineFactory"/>
Index: ChangeLog
===================================================================
--- ChangeLog	(revision 8883)
+++ ChangeLog	(working copy)
@@ -1,3 +1,9 @@
+2016-07-20  Jamison Hope  <jrh@theptrgroup.com>
+
+	* build.xml (script-factory-scheme, script-factory-xquery): Make
+	sure META-INF/services directory exists before writing to
+	META-INF/services/javax.script.ScriptEngineFactory file.
+
 2016-07-13  Per Bothner  <per@bothner.com>
 
 	Replace use of JFreeSVG with VectorGraphics2D library.

             reply	other threads:[~2016-07-20 17:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-20 17:18 Jamison Hope [this message]
2016-07-21  6:38 ` Per Bothner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5DF8F292-6E3C-4A18-BBCC-5F5C77FB5517@theptrgroup.com \
    --to=jrh@theptrgroup.com \
    --cc=kawa@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).