From: Per Bothner <per@bothner.com>
To: Michael Zucchi <notzed@gmail.com>, kawa@sourceware.org
Subject: Re: building for jdk / openfx 13 (patch)
Date: Tue, 17 Dec 2019 01:20:00 -0000 [thread overview]
Message-ID: <af442ce5-5db0-37c6-8256-078a0293ea6c@bothner.com> (raw)
In-Reply-To: <55c6385c-84ae-439d-0336-abc41085ac82@gmail.com>
On 12/16/19 3:43 PM, Michael Zucchi wrote:
> Apologies if this should go to the bug tracker, I didn't see any specific details for patch submission.
email is fine.
> I wanted to have a look at kawa including the javafx parts but I didn't want to install the oracle jdk as i've moved everything i do to openjdk. So I've created a small patch that allows compilation with openjdk13 and openjfx13 (although it should work with 11+). It is enabled by adding --with-javafx-sdk=path to configure:
We already have a --with-javafx, with optional argument: --with-javafx=ARG.
The ARG is used to set WITH_JAVAFX_ARG, which was intended to be used
to specify the path the JavaFX, but doesn't seem to be used.
So probably we should use WITH_JAVAFX_ARG instead of WITH_JAVAFX_SDK_ARG.
The configure script might need to check that the ARG specified for
--with-javafx is for java 9 or later - i.e. modularized.
--
--Per Bothner
per@bothner.com http://per.bothner.com/
next prev parent reply other threads:[~2019-12-17 1:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 23:43 Michael Zucchi
2019-12-16 23:49 ` ian
2019-12-17 1:53 ` Per Bothner
2019-12-17 1:20 ` Per Bothner [this message]
2019-12-17 3:51 ` Michael Zucchi
2019-12-17 5:58 ` Per Bothner
2019-12-17 6:31 ` Michael Zucchi
2019-12-19 17:51 ` Per Bothner
2019-12-19 20:05 ` spellcard199
2019-12-19 20:09 ` Per Bothner
2019-12-20 1:43 ` Per Bothner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af442ce5-5db0-37c6-8256-078a0293ea6c@bothner.com \
--to=per@bothner.com \
--cc=kawa@sourceware.org \
--cc=notzed@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).