From: Per Bothner <per@bothner.com>
To: "Timo Myyrä" <timo.myyra@wickedbsd.net>, kawa@sourceware.org
Subject: Re: [PATCH 1/2] Tweak xquery tests so that they pass on OpenBSD
Date: Mon, 08 May 2017 18:39:00 -0000 [thread overview]
Message-ID: <ea828d30-233d-4f4a-78d6-3610b19e6b53@bothner.com> (raw)
In-Reply-To: <8737cfl2qj.fsf@phobos.TeleWell.gateway>
On 05/07/2017 09:11 PM, Timo Myyrä wrote:
>
> OpenBSD's diff doesn't have -B flag so work around it by formatting the
> expected test outputs to not have newline in the end.
I'm not comfortable changing checked-in text files so they don't end
in a newline, like text files should.
Ideally the output should always (or at least by default) end in a newline.
Perhaps close should automatically call freshLine. However, you have to
be careful with binary files - and it becomes non-obvious with hybrid
text/binary files, which Kawa supports.
So not sure what to do. It needs some thought.
As a work-round until then, I suggest we add a newline to the end of the output.
For example:
echo >>tmp-format-users.html
Or perhaps we can have sed add the newline.
--
--Per Bothner
per@bothner.com http://per.bothner.com/
next prev parent reply other threads:[~2017-05-08 18:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-08 16:42 Timo Myyrä
2017-05-08 18:39 ` Per Bothner [this message]
2017-05-09 4:02 ` Timo Myyrä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea828d30-233d-4f4a-78d6-3610b19e6b53@bothner.com \
--to=per@bothner.com \
--cc=kawa@sourceware.org \
--cc=timo.myyra@wickedbsd.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).