From: "Guillermo E. Martinez" <guillermo.e.martinez@oracle.com>
To: Dodji Seketeli <dodji@seketeli.org>
Cc: libabigail@sourceware.org
Subject: Re: [PATCH] abipkgdiff: Add support to compare packages with CTF debug format
Date: Tue, 17 May 2022 08:13:44 -0500 [thread overview]
Message-ID: <15358250.O9o76ZdvQC@sali> (raw)
In-Reply-To: <87r14styzj.fsf@seketeli.org>
On Tuesday, May 17, 2022 2:11:28 AM CDT Dodji Seketeli wrote:
> Hello Guillermo,
Hello Dodji,
> "Guillermo E. Martinez" <guillermo.e.martinez@oracle.com> a écrit:
>
> [...]
>
> >> abigail::ctf_reader::create_read_context only takes two parameters:
> >> elf1.path and env.get(). So I removed the di_dirs1 one.
> > Oh, this is because there is a previous patch to use the `di_dirs1' parameters:
> > https://sourceware.org/pipermail/libabigail/2022q2/004361.html[1]
> > my fault, for get mentioned it.
>
> No problem, I'll look at that one, apply it, and perform the necessary
> modifications.
>
> Maybe in the future, if you have patches that depends on each other like
> that, it's better to post a complete patch-set, rather than posting them
> one by one?
ok, understood.
> In any case, thank you for working on this, it's appreciated.
>
> [...]
>
> Cheers,
Thanks!,
guillermo
prev parent reply other threads:[~2022-05-17 13:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-07 2:03 Guillermo E. Martinez
2022-05-16 22:09 ` Dodji Seketeli
2022-05-16 22:21 ` Guillermo E. Martinez
2022-05-17 7:11 ` Dodji Seketeli
2022-05-17 13:13 ` Guillermo E. Martinez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15358250.O9o76ZdvQC@sali \
--to=guillermo.e.martinez@oracle.com \
--cc=dodji@seketeli.org \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).