Re: [PATCH] abipkgdiff: Add support to compare packages with CTF debug format

["Guillermo E. Martinez" <guillermo.e.martinez@oracle.com>]

On Monday, May 16, 2022 5:09:51 PM CDT Dodji Seketeli wrote:
> Hello Guillermo,
Hello Dodji,

> "Guillermo E. Martinez via Libabigail" <libabigail@sourceware.org> a
> écrit:
> 
> I have applied the patch to master, thank you very much for it!
> 
> I have however made some little adjustments.  Please read about them
> below.
Ok, thanks! 
> commit a433820d809bfa134210f5647ee2d1e303d591e7
> Author: Guillermo E. Martinez <guillermo.e.martinez@oracle.com>
> Date:   Fri May 6 21:03:26 2022 -0500
> 
> [...]
> 
> > --- a/tools/abipkgdiff.cc
> > +++ b/tools/abipkgdiff.cc
> 
> [...]
> 
> > +#ifdef WITH_CTF
> > +    if (opts.use_ctf)
> > +      {
> > +        ctxt_ctf = abigail::ctf_reader::create_read_context(elf1.path,
> > +                                                            di_dirs1,
> > +                                                            env.get());
> 
> abigail::ctf_reader::create_read_context only takes two parameters:
> elf1.path and env.get().  So I removed the di_dirs1 one.
Oh, this is because there is a previous patch to use the `di_dirs1' parameters:
https://sourceware.org/pipermail/libabigail/2022q2/004361.html[1]
my  fault, for get mentioned it.
> [...]
> 
> 
> > +#ifdef WITH_CTF
> > +    if (opts.use_ctf)
> > +      {
> > +        ctxt_ctf = abigail::ctf_reader::create_read_context
> > +          (elf2.path, di_dirs2, env.get());
> 
> Likewise.
> 
> > +#ifdef WITH_CTF
> > +    if (opts.use_ctf)
> > +      {
> > +        ctxt_ctf = abigail::ctf_reader::create_read_context(elf.path,
> > +                                                            di_dirs,
> > +                                                            env.get());
> 
> Likewise.
> 
> [...]
> 
>     
> >     This patch add support in `abipkgdiff' to compare binaries with CTF
> >     debug information inside of packages, when `--ctf' option is provided.
> >     
> >             * tools/abipkgdiff.cc: Include `abg-ctf-reader.h'.
> >             (options::use_ctf): Add new data member.
> >             (display_usage): Add `--ctf' usage.
> >             (compare): Add condition to use ctf-reader to extract
> >             (parse_command_line): Set `options::use_ctf' when --ctf
> >             option is provided.
> >             and build CTF corpora when `options::use_ctf' is set.
> >             (compare_to_self): Likewise.
> 
> Do you plan on adding some regression tests for this patch?  That
> would be neat and useful.
Yes, it will send soon :-)

> >     
> >     Signed-off-by: Guillermo E. Martinez <guillermo.e.martinez@oracle.com>
> 
> Applied the patch below to master, thanks!
Thanks!
 
> From 28a629347f598e3b5a35152538c4a4638ca3995a Mon Sep 17 00:00:00 2001
> From: "Guillermo E. Martinez" <guillermo.e.martinez@oracle.com>
> Date: Fri, 6 May 2022 21:03:26 -0500
> Subject: [PATCH] abipkgdiff: Add support to compare packages with CTF debug format
> 
> [...]



--------
[1] https://sourceware.org/pipermail/libabigail/2022q2/004361.html