public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: Giuliano Procida <gprocida@google.com>
To: libabigail@sourceware.org
Cc: dodji@seketeli.org, kernel-team@android.com, gprocida@google.com,
	 maennich@google.com
Subject: [PATCH 0/2] Type identity clean-ups
Date: Fri, 19 Jun 2020 17:39:22 +0100	[thread overview]
Message-ID: <20200619163924.207852-1-gprocida@google.com> (raw)

Hi Dodji.

I've been looking at how libabigail compares types and decides two
types are the same. These are a couple of incidental commits prompted
by this investigation.

The commit message of the second patch below makes a couple of
statements as if they were true, but they are in fact somewhat
speculative. Please review with this in mind. Thanks!

Regards,
Giuliano.

Giuliano Procida (2):
  abg-ir.cc: Remove unused re_canonicalize function.
  Use pointers not strings in type graph comparison.

 include/abg-fwd.h                             |   3 -
 include/abg-ir.h                              |   5 -
 src/abg-ir.cc                                 |  37 +-
 .../PR25058-liblttng-ctl-report-1.txt         | 239 +++++-
 ....el7.x86_64-multiple-sym-vers-report-0.txt |   2 +-
 ...l7.x86_64-0.12.8-1.el7.x86_64-report-2.txt | 734 ++++++++++++------
 ...l7.x86_64-0.12.8-1.el7.x86_64-report-3.txt | 162 +++-
 7 files changed, 909 insertions(+), 273 deletions(-)

-- 
2.27.0.111.gc72c7da667-goog


             reply	other threads:[~2020-06-19 16:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-19 16:39 Giuliano Procida [this message]
2020-06-19 16:39 ` [PATCH 1/2] abg-ir.cc: Remove unused re_canonicalize function Giuliano Procida
2020-07-07 14:48   ` Dodji Seketeli
2020-06-19 16:39 ` [PATCH 2/2] Use pointers not strings in type graph comparison Giuliano Procida
2020-07-09  9:19   ` Dodji Seketeli
2020-06-22 20:11 ` [PATCH 0/2] Type identity clean-ups Matthias Maennich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200619163924.207852-1-gprocida@google.com \
    --to=gprocida@google.com \
    --cc=dodji@seketeli.org \
    --cc=kernel-team@android.com \
    --cc=libabigail@sourceware.org \
    --cc=maennich@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).