From: Dodji Seketeli <dodji@seketeli.org>
To: Giuliano Procida <gprocida@google.com>
Cc: libabigail@sourceware.org, kernel-team@android.com,
maennich@google.com
Subject: Re: [PATCH 1/2] abg-ir.cc: Remove unused re_canonicalize function.
Date: Tue, 07 Jul 2020 16:48:45 +0200 [thread overview]
Message-ID: <878sfvs7n6.fsf@seketeli.org> (raw)
In-Reply-To: <20200619163924.207852-2-gprocida@google.com> (Giuliano Procida's message of "Fri, 19 Jun 2020 17:39:23 +0100")
Giuliano Procida <gprocida@google.com> a écrit:
> The function re_canonicalize was added in commit:
>
> 286cadf8 Bug 24430 - Fold away const for array types
>
> but later rendered obsolete by commit:
>
> 5d6af8d5 Delay canonicalization for array and qualified types
>
> This commit removes the function and its associated declarations.
>
> * include/abg-fwd.h (re_canonicalize): Remove declaration of
> obsolete function.
> * include/abg-ir.h (class {decl_base, type_base}): Remove
> re_canonicalize friend declarations from these classes.
> * src/abg-ir.cc (re_canonicalize): Remove obsolete function.
>
> Signed-off-by: Giuliano Procida <gprocida@google.com>
Applied to master, thanks!
Cheers,
--
Dodji
next prev parent reply other threads:[~2020-07-07 14:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 16:39 [PATCH 0/2] Type identity clean-ups Giuliano Procida
2020-06-19 16:39 ` [PATCH 1/2] abg-ir.cc: Remove unused re_canonicalize function Giuliano Procida
2020-07-07 14:48 ` Dodji Seketeli [this message]
2020-06-19 16:39 ` [PATCH 2/2] Use pointers not strings in type graph comparison Giuliano Procida
2020-07-09 9:19 ` Dodji Seketeli
2020-06-22 20:11 ` [PATCH 0/2] Type identity clean-ups Matthias Maennich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878sfvs7n6.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).