From: Giuliano Procida <gprocida@google.com>
To: libabigail@sourceware.org
Cc: dodji@seketeli.org, kernel-team@android.com, gprocida@google.com,
maennich@google.com
Subject: [PATCH v3 0/1] Fix abidiff exit code when diffs are suppressed
Date: Wed, 1 Jul 2020 14:19:06 +0100 [thread overview]
Message-ID: <20200701131907.2665674-1-gprocida@google.com> (raw)
In-Reply-To: <20200330091754.GH101337@google.com>
This is an update for a patch sent for review a while ago.
We're been running with the previous version for a while and
discovered the fix was incomplete. This version includes tests (as
requested in review) to verify the expected behaviour.
Regards,
Giuliano.
Giuliano Procida (1):
Fix has_net_changes for --leaf-changes-only mode
src/abg-comparison.cc | 26 +++++++----
tests/data/Makefile.am | 9 ++++
.../test-net-change-report0.txt | 43 ++++++++++++++++++
.../test-net-change-report1.txt | 3 ++
.../test-net-change-report2.txt | 42 +++++++++++++++++
.../test-net-change-report3.txt | 5 ++
.../test-abidiff-exit/test-net-change-v0.c | 14 ++++++
.../test-abidiff-exit/test-net-change-v0.o | Bin 0 -> 3512 bytes
.../test-abidiff-exit/test-net-change-v1.c | 14 ++++++
.../test-abidiff-exit/test-net-change-v1.o | Bin 0 -> 3552 bytes
.../test-net-change.abignore | 8 ++++
tests/test-abidiff-exit.cc | 38 ++++++++++++++++
12 files changed, 192 insertions(+), 10 deletions(-)
create mode 100644 tests/data/test-abidiff-exit/test-net-change-report0.txt
create mode 100644 tests/data/test-abidiff-exit/test-net-change-report1.txt
create mode 100644 tests/data/test-abidiff-exit/test-net-change-report2.txt
create mode 100644 tests/data/test-abidiff-exit/test-net-change-report3.txt
create mode 100644 tests/data/test-abidiff-exit/test-net-change-v0.c
create mode 100644 tests/data/test-abidiff-exit/test-net-change-v0.o
create mode 100644 tests/data/test-abidiff-exit/test-net-change-v1.c
create mode 100644 tests/data/test-abidiff-exit/test-net-change-v1.o
create mode 100644 tests/data/test-abidiff-exit/test-net-change.abignore
--
2.27.0.212.ge8ba1cc988-goog
next prev parent reply other threads:[~2020-07-01 13:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 17:13 [RFC] Fix has_net_changes for leaf-changes-only mode Giuliano Procida
2020-03-24 17:17 ` Giuliano Procida
2020-03-26 10:37 ` Matthias Maennich
2020-03-26 12:01 ` Giuliano Procida
2020-03-26 17:12 ` Dodji Seketeli
2020-03-27 18:42 ` Giuliano Procida
2020-03-27 19:01 ` [PATCH v2] Fix has_net_changes for --leaf-changes-only mode Giuliano Procida
2020-03-30 9:17 ` Matthias Maennich
2020-07-01 13:19 ` Giuliano Procida [this message]
2020-07-01 13:19 ` [PATCH v3 1/1] " Giuliano Procida
2020-07-17 13:54 ` Dodji Seketeli
2020-07-17 16:34 ` Giuliano Procida
2020-07-21 6:28 ` Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200701131907.2665674-1-gprocida@google.com \
--to=gprocida@google.com \
--cc=dodji@seketeli.org \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).