From: Giuliano Procida <gprocida@google.com>
To: libabigail@sourceware.org
Cc: dodji@seketeli.org, kernel-team@android.com, gprocida@google.com,
maennich@google.com
Subject: [RFC PATCH 0/1] Fix decl_base comparison
Date: Wed, 22 Jul 2020 12:07:35 +0100 [thread overview]
Message-ID: <20200722110736.2550361-1-gprocida@google.com> (raw)
Hi reviewers.
This commit fixes the slow path decl_base comparison, with the
assumption that decl_names_equal has been fixed as per another commit,
"Make decl_names_equal more accurate".
This is an RFC patch because there may be more to address here. I've
added some TODOs and referred to them in the commit message for the
patch. I'm hoping for review comments particularly directed at those
TODOs.
To be clear, disabling the fast path in the decl_base comparison
changes behaviour, suggesting that the fast path is buggy as well.
Regards,
Giuliano.
Giuliano Procida (1):
Fix decl_base comparison function
src/abg-ir.cc | 25 +-
.../PR25058-liblttng-ctl-report-1.txt | 4 -
.../data/test-diff-filter/test33-report-0.txt | 3 -
....el7.x86_64-multiple-sym-vers-report-0.txt | 2 +-
...l7.x86_64-0.12.8-1.el7.x86_64-report-2.txt | 2 +-
.../test9-pr18818-clang.so.abi | 236 ++++++++----------
6 files changed, 127 insertions(+), 145 deletions(-)
--
2.28.0.rc0.105.gf9edc3c819-goog
next reply other threads:[~2020-07-22 11:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 11:07 Giuliano Procida [this message]
2020-07-22 11:07 ` [RFC PATCH 1/1] Fix decl_base comparison function Giuliano Procida
2020-08-04 15:07 ` Dodji Seketeli
2020-08-04 15:47 ` Giuliano Procida
2020-08-04 17:16 ` Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200722110736.2550361-1-gprocida@google.com \
--to=gprocida@google.com \
--cc=dodji@seketeli.org \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).