From: Giuliano Procida <gprocida@google.com>
To: libabigail@sourceware.org
Cc: dodji@seketeli.org, kernel-team@android.com, gprocida@google.com,
maennich@google.com
Subject: [PATCH 0/1] Fix union member access specifiers
Date: Mon, 15 Mar 2021 16:04:17 +0000 [thread overview]
Message-ID: <20210315160418.153481-1-gprocida@google.com> (raw)
Hi Dodji.
I found a few places in the code that that appeared to be doing the
wrong things for unions which (like structs) should have members as
public by default.
Each of the 3 changes affected some tests. Only one of them affected a
small test case I put together, so I've omitted that from the patch.
FTR it's:
union U {
int public_0;
void public_1() { }
public:
int public_2;
void public_3() { }
protected:
int protected_4;
void protected_5() { }
private:
int private_6;
void private_7() { }
};
struct S {
int public_0;
void public_1() { }
public:
int public_2;
void public_3() { }
protected:
int protected_4;
void protected_5() { }
private:
int private_6;
void private_7() { }
};
class C {
int private_0;
void private_1() { }
public:
int public_2;
void public_3() { }
protected:
int protected_4;
void protected_5() { }
private:
int private_6;
void private_7() { }
};
void fun(U, S, C) {
}
Please do double-check I've touched all the right bits of code.
Thanks!
Giuliano.
Giuliano Procida (1):
abidw: Treat union members as public by default.
src/abg-dwarf-reader.cc | 20 +-
.../test-annotate/libtest24-drop-fns-2.so.abi | 4 +-
.../test-annotate/libtest24-drop-fns.so.abi | 4 +-
.../test-anonymous-members-0.o.abi | 8 +-
.../data/test-annotate/test13-pr18894.so.abi | 4 +-
.../data/test-annotate/test14-pr18893.so.abi | 8 +-
.../data/test-annotate/test15-pr18892.so.abi | 40 +-
.../data/test-annotate/test17-pr19027.so.abi | 282 ++--
...st18-pr19037-libvtkRenderingLIC-6.1.so.abi | 12 +-
...19-pr19023-libtcmalloc_and_profiler.so.abi | 84 +-
...st20-pr19025-libvtkParallelCore-6.1.so.abi | 12 +-
.../data/test-annotate/test21-pr19092.so.abi | 118 +-
.../PR25409-librte_bus_dpaa.so.20.0.abi | 238 +--
.../test0-pr19026-libvtkIOSQL-6.1.so.1.abi | 1384 ++++++++---------
.../PR22015-libboost_iostreams.so.abi | 4 +-
.../data/test-read-dwarf/PR25007-sdhci.ko.abi | 208 +--
.../libtest24-drop-fns-2.so.abi | 4 +-
.../test-read-dwarf/libtest24-drop-fns.so.abi | 4 +-
.../data/test-read-dwarf/test-PR26568-1.o.abi | 4 +-
.../data/test-read-dwarf/test-PR26568-2.o.abi | 4 +-
.../test-read-dwarf/test-libandroid.so.abi | 240 +--
.../test-read-dwarf/test10-pr18818-gcc.so.abi | 8 +-
.../test-read-dwarf/test11-pr18828.so.abi | 52 +-
.../test-read-dwarf/test12-pr18844.so.abi | 106 +-
.../test-read-dwarf/test13-pr18894.so.abi | 4 +-
.../test-read-dwarf/test14-pr18893.so.abi | 8 +-
.../test-read-dwarf/test15-pr18892.so.abi | 40 +-
.../test-read-dwarf/test16-pr18904.so.abi | 58 +-
.../test-read-dwarf/test17-pr19027.so.abi | 282 ++--
...st18-pr19037-libvtkRenderingLIC-6.1.so.abi | 12 +-
...19-pr19023-libtcmalloc_and_profiler.so.abi | 84 +-
...st20-pr19025-libvtkParallelCore-6.1.so.abi | 12 +-
.../test-read-dwarf/test21-pr19092.so.abi | 118 +-
.../test22-pr19097-libstdc++.so.6.0.17.so.abi | 80 +-
.../test9-pr18818-clang.so.abi | 12 +-
35 files changed, 1781 insertions(+), 1781 deletions(-)
--
2.31.0.rc2.261.g7f71774620-goog
next reply other threads:[~2021-03-15 16:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 16:04 Giuliano Procida [this message]
2021-03-15 16:04 ` [PATCH 1/1] abidw: Treat union members as public by default Giuliano Procida
2021-03-19 16:40 ` Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210315160418.153481-1-gprocida@google.com \
--to=gprocida@google.com \
--cc=dodji@seketeli.org \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).