From: Dodji Seketeli <dodji@seketeli.org>
To: Giuliano Procida <gprocida@google.com>
Cc: libabigail@sourceware.org, kernel-team@android.com,
maennich@google.com
Subject: Re: [PATCH 1/1] abidw: Treat union members as public by default.
Date: Fri, 19 Mar 2021 17:40:09 +0100 [thread overview]
Message-ID: <87a6qzw106.fsf@seketeli.org> (raw)
In-Reply-To: <20210315160418.153481-2-gprocida@google.com> (Giuliano Procida's message of "Mon, 15 Mar 2021 16:04:18 +0000")
Hello,
Giuliano Procida <gprocida@google.com> a écrit:
> This fixes a bug where abidw reports the access of members of C unions
> and of C++ unions without any access specifiers as private.
>
> * src/abg-dwarf-reader.cc (add_or_update_union_type): Replace
> "class" with "union" in comments; give union members public
> access by default. (finish_member_function_reading):
> Give union members public access by default.
I edited the ChangeLog a bit to fix the formatting.
> (maybe_set_member_type_access_specifier): Give union members
> public access by default.
> * tests/data/test-annotate/libtest24-drop-fns-2.so.abi:
> Refresh.
> * tests/data/test-annotate/libtest24-drop-fns.so.abi:
> Refresh.
> * tests/data/test-annotate/test-anonymous-members-0.o.abi:
> Refresh.
> * tests/data/test-annotate/test13-pr18894.so.abi: Refresh.
> * tests/data/test-annotate/test14-pr18893.so.abi: Refresh.
> * tests/data/test-annotate/test15-pr18892.so.abi: Refresh.
> * tests/data/test-annotate/test17-pr19027.so.abi: Refresh.
> * tests/data/test-annotate/test18-pr19037-libvtkRenderingLIC-6.1.so.abi:
> Refresh.
> * tests/data/test-annotate/test19-pr19023-libtcmalloc_and_profiler.so.abi:
> Refresh.
> * tests/data/test-annotate/test20-pr19025-libvtkParallelCore-6.1.so.abi:
> Refresh.
> * tests/data/test-annotate/test21-pr19092.so.abi: Refresh.
> * tests/data/test-diff-dwarf-abixml/PR25409-librte_bus_dpaa.so.20.0.abi:
> Refresh.
> * tests/data/test-diff-dwarf-abixml/test0-pr19026-libvtkIOSQL-6.1.so.1.abi:
> Refresh.
> * tests/data/test-read-dwarf/PR22015-libboost_iostreams.so.abi:
> Refresh.
> * tests/data/test-read-dwarf/PR25007-sdhci.ko.abi: Refresh.
> * tests/data/test-read-dwarf/libtest24-drop-fns-2.so.abi:
> Refresh.
> * tests/data/test-read-dwarf/libtest24-drop-fns.so.abi:
> Refresh.
> * tests/data/test-read-dwarf/test-PR26568-1.o.abi: Refresh.
> * tests/data/test-read-dwarf/test-PR26568-2.o.abi: Refresh.
> * tests/data/test-read-dwarf/test-libandroid.so.abi: Refresh.
> * tests/data/test-read-dwarf/test10-pr18818-gcc.so.abi:
> Refresh.
> * tests/data/test-read-dwarf/test11-pr18828.so.abi: Refresh.
> * tests/data/test-read-dwarf/test12-pr18844.so.abi: Refresh.
> * tests/data/test-read-dwarf/test13-pr18894.so.abi: Refresh.
> * tests/data/test-read-dwarf/test14-pr18893.so.abi: Refresh.
> * tests/data/test-read-dwarf/test15-pr18892.so.abi: Refresh.
> * tests/data/test-read-dwarf/test16-pr18904.so.abi: Refresh.
> * tests/data/test-read-dwarf/test17-pr19027.so.abi: Refresh.
> * tests/data/test-read-dwarf/test18-pr19037-libvtkRenderingLIC-6.1.so.abi:
> Refresh.
> * tests/data/test-read-dwarf/test19-pr19023-libtcmalloc_and_profiler.so.abi:
> Refresh.
> * tests/data/test-read-dwarf/test20-pr19025-libvtkParallelCore-6.1.so.abi:
> Refresh.
> * tests/data/test-read-dwarf/test21-pr19092.so.abi: Refresh.
> * tests/data/test-read-dwarf/test22-pr19097-libstdc++.so.6.0.17.so.abi:
> Refresh.
> * tests/data/test-read-dwarf/test9-pr18818-clang.so.abi:
> Refresh.
>
> Signed-off-by: Giuliano Procida <gprocida@google.com>
Applied to master, thanks!
[...]
--
Dodji
prev parent reply other threads:[~2021-03-21 11:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 16:04 [PATCH 0/1] Fix union member access specifiers Giuliano Procida
2021-03-15 16:04 ` [PATCH 1/1] abidw: Treat union members as public by default Giuliano Procida
2021-03-19 16:40 ` Dodji Seketeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6qzw106.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).