From: Giuliano Procida <gprocida@google.com>
To: libabigail@sourceware.org
Cc: dodji@seketeli.org, kernel-team@android.com, gprocida@google.com,
maennich@google.com
Subject: [RFC PATCH 1/3] XML writer: treat function types more uniformly
Date: Fri, 7 May 2021 19:42:48 +0100 [thread overview]
Message-ID: <20210507184250.3946416-2-gprocida@google.com> (raw)
In-Reply-To: <20210507184250.3946416-1-gprocida@google.com>
Bug 26591 - detect pathologically redundant types in abixml
The XML writer has some special treatment of function types (compared
with pointer types, for example). This commit removes the special
treatment.
While I believe this is a safe and reasonably sensible thing to do,
the real reason for this change is that it makes the following changes
to eliminate duplicate types work properly.
* src/abg-writer.cc (fn_type_ptr_set_type): Remove typedef.
(writer_context::m_referenced_fn_types_set): Remove member.
(writer_context::get_referenced_types): Adjust documentation.
(writer_context::get_referenced_non_canonical_types): Ditto.
(writer_context::record_type_as_referenced): Adjust
documentation and remove special handling of function types.
(writer_context::type_is_referenced): Ditto.
(writer_context::clear something): Remove special handling of
function types.
(writer_context::write_translation_unit): Adjust comments.
Remove special handling of function types. Drop code that
attempts to emit live TU function types that are referenced
and unemitted.
* tests/data/test-annotate/test13-pr18894.so.abi: Refresh.
* tests/data/test-annotate/test14-pr18893.so.abi: Refresh.
* tests/data/test-annotate/test15-pr18892.so.abi: Refresh.
* tests/data/test-annotate/test17-pr19027.so.abi: Refresh.
* tests/data/test-annotate/test19-pr19023-libtcmalloc_and_profiler.so.abi:
Refresh.
* tests/data/test-annotate/test20-pr19025-libvtkParallelCore-6.1.so.abi:
Refresh.
* tests/data/test-annotate/test21-pr19092.so.abi: Refresh.
* tests/data/test-read-dwarf/PR25042-libgdbm-clang-dwarf5.so.6.0.0.abi:
Refresh.
* tests/data/test-read-dwarf/test-libandroid.so.abi: Refresh.
* tests/data/test-read-dwarf/test12-pr18844.so.abi: Refresh.
* tests/data/test-read-dwarf/test13-pr18894.so.abi: Refresh.
* tests/data/test-read-dwarf/test14-pr18893.so.abi: Refresh.
* tests/data/test-read-dwarf/test15-pr18892.so.abi: Refresh.
* tests/data/test-read-dwarf/test16-pr18904.so.abi: Refresh.
* tests/data/test-read-dwarf/test17-pr19027.so.abi: Refresh.
* tests/data/test-read-dwarf/test19-pr19023-libtcmalloc_and_profiler.so.abi:
Refresh.
* tests/data/test-read-dwarf/test20-pr19025-libvtkParallelCore-6.1.so.abi:
Refresh.
* tests/data/test-read-dwarf/test21-pr19092.so.abi: Refresh.
* tests/data/test-read-dwarf/test22-pr19097-libstdc++.so.6.0.17.so.abi:
Refresh.
Signed-off-by: Giuliano Procida <gprocida@google.com>
---
src/abg-writer.cc | 77 +-
.../data/test-annotate/test13-pr18894.so.abi | 90 +-
.../data/test-annotate/test14-pr18893.so.abi | 1176 +-
.../data/test-annotate/test15-pr18892.so.abi | 14882 ++++++++--------
.../data/test-annotate/test17-pr19027.so.abi | 5277 +++---
...19-pr19023-libtcmalloc_and_profiler.so.abi | 4101 ++---
...st20-pr19025-libvtkParallelCore-6.1.so.abi | 44 +-
.../data/test-annotate/test21-pr19092.so.abi | 2774 +--
.../PR25042-libgdbm-clang-dwarf5.so.6.0.0.abi | 156 +-
.../test-read-dwarf/test-libandroid.so.abi | 54 +-
.../test-read-dwarf/test12-pr18844.so.abi | 22 +-
.../test-read-dwarf/test13-pr18894.so.abi | 50 +-
.../test-read-dwarf/test14-pr18893.so.abi | 1130 +-
.../test-read-dwarf/test15-pr18892.so.abi | 14709 +++++++--------
.../test-read-dwarf/test16-pr18904.so.abi | 14 +-
.../test-read-dwarf/test17-pr19027.so.abi | 4928 ++---
...19-pr19023-libtcmalloc_and_profiler.so.abi | 3949 ++--
...st20-pr19025-libvtkParallelCore-6.1.so.abi | 24 +-
.../test-read-dwarf/test21-pr19092.so.abi | 2100 +--
.../test22-pr19097-libstdc++.so.6.0.17.so.abi | 9292 +++++-----
20 files changed, 32750 insertions(+), 32099 deletions(-)
Patch too large to post here. See:
https://github.com/myxoid/libabigail/commit/3c7b1189ecec88cfb0bedd30d514ec84040c775e
next prev parent reply other threads:[~2021-05-07 18:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 18:42 [RFC PATCH 0/3] Bug 26591 - tentative fix for some duplicate type ids Giuliano Procida
2021-05-07 18:42 ` Giuliano Procida [this message]
2021-05-07 18:42 ` [RFC PATCH 2/3] XML writer: don't emit already emitted types Giuliano Procida
2021-05-07 18:42 ` [RFC PATCH 3/3] XML writer: emit enclosing types of scoped declarations Giuliano Procida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210507184250.3946416-2-gprocida@google.com \
--to=gprocida@google.com \
--cc=dodji@seketeli.org \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).