From: Giuliano Procida <gprocida@google.com>
To: libabigail@sourceware.org
Cc: dodji@seketeli.org, kernel-team@android.com, gprocida@google.com,
maennich@google.com
Subject: [RFC PATCH 2/3] XML writer: don't emit already emitted types
Date: Fri, 7 May 2021 19:42:49 +0100 [thread overview]
Message-ID: <20210507184250.3946416-3-gprocida@google.com> (raw)
In-Reply-To: <20210507184250.3946416-1-gprocida@google.com>
The XML writer sometimes emits type definitions entirely duplicated.
This happens if for some reason a type is emitted early but is later
emitted as one of the canonical types associated with a translation
unit.
Bug 26591 - detect pathologically redundant types in abixml
* src/abg-writer.cc:
(writer_context::write_canonical_types_of_scope): Do not emit
already emitted types.
* tests/data/test-annotate/test13-pr18894.so.abi: Refresh.
* tests/data/test-annotate/test14-pr18893.so.abi: Refresh.
* tests/data/test-annotate/test15-pr18892.so.abi: Refresh.
* tests/data/test-annotate/test17-pr19027.so.abi: Refresh.
* tests/data/test-annotate/test18-pr19037-libvtkRenderingLIC-6.1.so.abi:
Refresh.
* tests/data/test-annotate/test19-pr19023-libtcmalloc_and_profiler.so.abi:
Refresh.
* tests/data/test-annotate/test20-pr19025-libvtkParallelCore-6.1.so.abi:
Refresh.
* tests/data/test-annotate/test21-pr19092.so.abi: Refresh.
* tests/data/test-read-dwarf/PR22015-libboost_iostreams.so.abi:
Refresh.
* tests/data/test-read-dwarf/PR22122-libftdc.so.abi: Refresh.
* tests/data/test-read-dwarf/PR25042-libgdbm-clang-dwarf5.so.6.0.0.abi:
Refresh.
* tests/data/test-read-dwarf/PR26261/PR26261-exe.abi: Refresh.
* tests/data/test-read-dwarf/test-libandroid.so.abi: Refresh.
* tests/data/test-read-dwarf/test10-pr18818-gcc.so.abi: Refresh.
* tests/data/test-read-dwarf/test12-pr18844.so.abi: Refresh.
* tests/data/test-read-dwarf/test13-pr18894.so.abi: Refresh.
* tests/data/test-read-dwarf/test14-pr18893.so.abi: Refresh.
* tests/data/test-read-dwarf/test15-pr18892.so.abi: Refresh.
* tests/data/test-read-dwarf/test16-pr18904.so.abi: Refresh.
* tests/data/test-read-dwarf/test17-pr19027.so.abi: Refresh.
* tests/data/test-read-dwarf/test18-pr19037-libvtkRenderingLIC-6.1.so.abi:
Refresh.
* tests/data/test-read-dwarf/test19-pr19023-libtcmalloc_and_profiler.so.abi:
Refresh.
* tests/data/test-read-dwarf/test20-pr19025-libvtkParallelCore-6.1.so.abi:
Refresh.
* tests/data/test-read-dwarf/test21-pr19092.so.abi: Refresh.
* tests/data/test-read-dwarf/test22-pr19097-libstdc++.so.6.0.17.so.abi:
Refresh.
* tests/data/test-read-dwarf/test9-pr18818-clang.so.abi: Refresh.
Signed-off-by: Giuliano Procida <gprocida@google.com>
---
src/abg-writer.cc | 2 +-
.../data/test-annotate/test13-pr18894.so.abi | 208 -
.../data/test-annotate/test14-pr18893.so.abi | 4680 +-
.../data/test-annotate/test15-pr18892.so.abi | 10977 ++--
.../data/test-annotate/test17-pr19027.so.abi | 13461 +---
...st18-pr19037-libvtkRenderingLIC-6.1.so.abi | 726 +-
...19-pr19023-libtcmalloc_and_profiler.so.abi | 4726 +-
...st20-pr19025-libvtkParallelCore-6.1.so.abi | 7850 +--
.../data/test-annotate/test21-pr19092.so.abi | 2017 +-
.../PR22015-libboost_iostreams.so.abi | 10 -
.../test-read-dwarf/PR22122-libftdc.so.abi | 5 -
.../PR25042-libgdbm-clang-dwarf5.so.6.0.0.abi | 279 -
.../test-read-dwarf/PR26261/PR26261-exe.abi | 4 -
.../test-read-dwarf/test-libandroid.so.abi | 2124 +-
.../test-read-dwarf/test10-pr18818-gcc.so.abi | 20 -
.../test-read-dwarf/test12-pr18844.so.abi | 2821 +-
.../test-read-dwarf/test13-pr18894.so.abi | 134 -
.../test-read-dwarf/test14-pr18893.so.abi | 3019 +-
.../test-read-dwarf/test15-pr18892.so.abi | 3101 +-
.../test-read-dwarf/test16-pr18904.so.abi | 1084 +-
.../test-read-dwarf/test17-pr19027.so.abi | 8154 +--
...st18-pr19037-libvtkRenderingLIC-6.1.so.abi | 428 -
...19-pr19023-libtcmalloc_and_profiler.so.abi | 2920 +-
...st20-pr19025-libvtkParallelCore-6.1.so.abi | 4427 +-
.../test-read-dwarf/test21-pr19092.so.abi | 1587 +-
.../test22-pr19097-libstdc++.so.6.0.17.so.abi | 50566 ++++++----------
.../test9-pr18818-clang.so.abi | 38 -
27 files changed, 33379 insertions(+), 91989 deletions(-)
Patch too large to post here. See:
https://github.com/myxoid/libabigail/commit/e3f22b080743b41253f72558206109a0f94a292d
next prev parent reply other threads:[~2021-05-07 18:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 18:42 [RFC PATCH 0/3] Bug 26591 - tentative fix for some duplicate type ids Giuliano Procida
2021-05-07 18:42 ` [RFC PATCH 1/3] XML writer: treat function types more uniformly Giuliano Procida
2021-05-07 18:42 ` Giuliano Procida [this message]
2021-05-07 18:42 ` [RFC PATCH 3/3] XML writer: emit enclosing types of scoped declarations Giuliano Procida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210507184250.3946416-3-gprocida@google.com \
--to=gprocida@google.com \
--cc=dodji@seketeli.org \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).