public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: Giuliano Procida <gprocida@google.com>
To: libabigail@sourceware.org
Cc: dodji@seketeli.org, kernel-team@android.com, gprocida@google.com,
	 maennich@google.com
Subject: [PATCH 0/4] Looking at equality and hashing
Date: Fri, 10 Sep 2021 12:23:21 +0100	[thread overview]
Message-ID: <20210910112325.806676-1-gprocida@google.com> (raw)

These relate to PR28320.

The first two patches are essentially code movement to better isolate
where insertions and look-ups happen.

The third patch adds some optional consistency checks. These find one
issue in the test suite. Unfortunately, they do not pick up on issue
in PR28320 itself. Perhaps there is a canonical type pointer issue as
well.

The last patch seems like an omission. Please take a look.

Giuliano Procida (4):
  abg-writer: get_id_for_type: refactor insertion and look-up
  abg-writer: refactor recording of unemitted types
  abg-writer: allow debugging of equality / hash issues
  RFC: abg-writer: add a missing check for emitted declarations

 configure.ac      |  16 ++++
 src/abg-writer.cc | 184 +++++++++++++++++++++++++++++++---------------
 2 files changed, 139 insertions(+), 61 deletions(-)

-- 
2.33.0.309.g3052b89438-goog


             reply	other threads:[~2021-09-10 11:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-10 11:23 Giuliano Procida [this message]
2021-09-10 11:23 ` [PATCH 1/4] abg-writer: get_id_for_type: refactor insertion and look-up Giuliano Procida
2021-09-10 11:23 ` [PATCH 2/4] abg-writer: refactor recording of unemitted types Giuliano Procida
2021-09-10 11:23 ` [PATCH 3/4] abg-writer: allow debugging of equality / hash issues Giuliano Procida
2021-09-10 11:23 ` [PATCH 4/4] RFC: abg-writer: add a missing check for emitted declarations Giuliano Procida

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210910112325.806676-1-gprocida@google.com \
    --to=gprocida@google.com \
    --cc=dodji@seketeli.org \
    --cc=kernel-team@android.com \
    --cc=libabigail@sourceware.org \
    --cc=maennich@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).