* [PATCH] Fix trivial typo when printing message
@ 2021-11-03 6:57 tangmeng
2021-11-09 9:41 ` Dodji Seketeli
0 siblings, 1 reply; 2+ messages in thread
From: tangmeng @ 2021-11-03 6:57 UTC (permalink / raw)
To: libabigail; +Cc: tangmeng
When abilint prints its tips information and abisym prints its
version string, it does not terminate it with a newline the way
that other commands do.
* tools/abilint.cc (man): End the 'FILE_TYPE_UNKNOWN' tips with a newline.
* tools/abisym.cc (man): Add a newline after version string.
Signed-off-by: tangmeng <tangmeng@uniontech.com>
---
tools/abilint.cc | 3 ++-
tools/abisym.cc | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/abilint.cc b/tools/abilint.cc
index b82543d2..3c78200a 100644
--- a/tools/abilint.cc
+++ b/tools/abilint.cc
@@ -327,7 +327,8 @@ main(int argc, char* argv[])
{
case abigail::tools_utils::FILE_TYPE_UNKNOWN:
emit_prefix(argv[0], cerr)
- << "Unknown file type given in input: " << opts.file_path;
+ << "Unknown file type given in input: " << opts.file_path
+ << "\n";
return 1;
case abigail::tools_utils::FILE_TYPE_NATIVE_BI:
tu = read_translation_unit_from_file(opts.file_path, env.get());
diff --git a/tools/abisym.cc b/tools/abisym.cc
index 5978fc99..e03a3222 100644
--- a/tools/abisym.cc
+++ b/tools/abisym.cc
@@ -121,7 +121,8 @@ main(int argc, char* argv[])
if (opts.display_version)
{
abigail::tools_utils::emit_prefix(argv[0], cout)
- << abigail::tools_utils::get_library_version_string();
+ << abigail::tools_utils::get_library_version_string()
+ << "\n";
return 0;
}
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix trivial typo when printing message
2021-11-03 6:57 [PATCH] Fix trivial typo when printing message tangmeng
@ 2021-11-09 9:41 ` Dodji Seketeli
0 siblings, 0 replies; 2+ messages in thread
From: Dodji Seketeli @ 2021-11-09 9:41 UTC (permalink / raw)
To: tangmeng; +Cc: libabigail
Hello,
tangmeng <tangmeng@uniontech.com> a écrit:
> When abilint prints its tips information and abisym prints its
> version string, it does not terminate it with a newline the way
> that other commands do.
>
> * tools/abilint.cc (man): End the 'FILE_TYPE_UNKNOWN' tips with a newline.
> * tools/abisym.cc (man): Add a newline after version string.
I have just changed 'man' into 'main' in this ChangeLog entry.
> Signed-off-by: tangmeng <tangmeng@uniontech.com>
Applied to master. Thanks!
Cheers,
--
Dodji
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-09 9:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-03 6:57 [PATCH] Fix trivial typo when printing message tangmeng
2021-11-09 9:41 ` Dodji Seketeli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).