From: Petr Pavlu <petr.pavlu@suse.com>
To: libabigail@sourceware.org
Cc: petr.pavlu@suse.com
Subject: [PATCH] abidiff: Fix handling of linux-kernel-mode
Date: Tue, 3 Jan 2023 11:28:55 +0100 [thread overview]
Message-ID: <20230103102855.21686-1-petr.pavlu@suse.com> (raw)
This fixes 08e76022 ("Support Linux Kernel ABI whitelist files") and
8fd02e0a ("Use the CTF reader by default when applicable").
The first commit removed handling of option --no-linux-kernel-mode. The
second one stopped passing opts.linux_kernel_mode down to the library
which also caused changing the default linux-kernel-mode of abidiff from
true to false. Both changes look unintentional as they are not mentioned
in either commit message.
Restore handling of the linux-kernel-mode in abidiff to match what is
described in doc/manuals/abidiff.rst and make it again consistent with
abidw.
* tools/abidiff.cc (parse_command_line): Recognize
--no-linux-kernel-mode.
(main): Pass opts.linux_kernel_mode down to the library.
Signed-off-by: Petr Pavlu <petr.pavlu@suse.com>
---
tools/abidiff.cc | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/tools/abidiff.cc b/tools/abidiff.cc
index b27d8b08..91a626a9 100644
--- a/tools/abidiff.cc
+++ b/tools/abidiff.cc
@@ -434,6 +434,8 @@ parse_command_line(int argc, char* argv[], options& opts)
opts.exported_interfaces_only = true;
else if (!strcmp(argv[i], "--allow-non-exported-interfaces"))
opts.exported_interfaces_only = false;
+ else if (!strcmp(argv[i], "--no-linux-kernel-mode"))
+ opts.linux_kernel_mode = false;
else if (!strcmp(argv[i], "--no-default-suppression"))
opts.no_default_supprs = true;
else if (!strcmp(argv[i], "--no-architecture"))
@@ -1235,7 +1237,8 @@ main(int argc, char* argv[])
create_best_elf_based_reader(opts.file1,
opts.prepared_di_root_paths1,
env, requested_fe_kind,
- opts.show_all_types);
+ opts.show_all_types,
+ opts.linux_kernel_mode);
ABG_ASSERT(rdr);
set_generic_options(*rdr, opts);
set_suppressions(*rdr, opts);
@@ -1307,7 +1310,8 @@ main(int argc, char* argv[])
create_best_elf_based_reader(opts.file2,
opts.prepared_di_root_paths2,
env, requested_fe_kind,
- opts.show_all_types);
+ opts.show_all_types,
+ opts.linux_kernel_mode);
ABG_ASSERT(rdr);
set_generic_options(*rdr, opts);
--
2.39.0
next reply other threads:[~2023-01-03 10:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 10:28 Petr Pavlu [this message]
2023-01-05 12:08 ` Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230103102855.21686-1-petr.pavlu@suse.com \
--to=petr.pavlu@suse.com \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).