From: Dodji Seketeli <dodji@seketeli.org>
To: Petr Pavlu via Libabigail <libabigail@sourceware.org>
Cc: Petr Pavlu <petr.pavlu@suse.com>
Subject: Re: [PATCH] abidiff: Fix handling of linux-kernel-mode
Date: Thu, 05 Jan 2023 13:08:09 +0100 [thread overview]
Message-ID: <87y1qhkwuu.fsf@seketeli.org> (raw)
In-Reply-To: <20230103102855.21686-1-petr.pavlu@suse.com> (Petr Pavlu via Libabigail's message of "Tue, 3 Jan 2023 11:28:55 +0100")
Hello Petr,
Petr Pavlu via Libabigail <libabigail@sourceware.org> a écrit:
> This fixes 08e76022 ("Support Linux Kernel ABI whitelist files") and
> 8fd02e0a ("Use the CTF reader by default when applicable").
>
> The first commit removed handling of option --no-linux-kernel-mode. The
> second one stopped passing opts.linux_kernel_mode down to the library
> which also caused changing the default linux-kernel-mode of abidiff from
> true to false. Both changes look unintentional as they are not mentioned
> in either commit message.
>
> Restore handling of the linux-kernel-mode in abidiff to match what is
> described in doc/manuals/abidiff.rst and make it again consistent with
> abidw.
>
> * tools/abidiff.cc (parse_command_line): Recognize
> --no-linux-kernel-mode.
> (main): Pass opts.linux_kernel_mode down to the library.
>
> Signed-off-by: Petr Pavlu <petr.pavlu@suse.com>
Applied to master, thanks!
[...]
Cheers,
--
Dodji
prev parent reply other threads:[~2023-01-05 12:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 10:28 Petr Pavlu
2023-01-05 12:08 ` Dodji Seketeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1qhkwuu.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=libabigail@sourceware.org \
--cc=petr.pavlu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).