From: "Guillermo E. Martinez" <guillermo.e.martinez@oracle.com>
To: libabigail@sourceware.org
Cc: "Guillermo E. Martinez" <guillermo.e.martinez@oracle.com>
Subject: [PATCH v2] abipkgdiff: Remove useless code to process kernel RPM packages
Date: Tue, 7 Mar 2023 12:57:28 -0600 [thread overview]
Message-ID: <20230307185728.107659-1-guillermo.e.martinez@oracle.com> (raw)
In-Reply-To: <20230306155038.3316079-1-guillermo.e.martinez@oracle.com>
In `abipkgdiff' working with a `kernel' package, the function
`get_vmlinux_path_from_kernel_dist' that looks for `vmlinux' file
in never reached, due to check an useless predicate.
* tools/abipkgdiff.cc
(compare_prepared_linux_kernel_packages): Remove useless predicate.
Signed-off-by: Guillermo E. Martinez <guillermo.e.martinez@oracle.com>
---
tools/abipkgdiff.cc | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/tools/abipkgdiff.cc b/tools/abipkgdiff.cc
index c2fc09ca..46b920a1 100644
--- a/tools/abipkgdiff.cc
+++ b/tools/abipkgdiff.cc
@@ -3106,8 +3106,7 @@ compare_prepared_linux_kernel_packages(package& first_package,
string vmlinux_path1, vmlinux_path2;
- if (!vmlinux_path1.empty()
- && !get_vmlinux_path_from_kernel_dist(debug_dir1, vmlinux_path1))
+ if (!get_vmlinux_path_from_kernel_dist(debug_dir1, vmlinux_path1))
{
emit_prefix("abipkgdiff", cerr)
<< "Could not find vmlinux in debuginfo package '"
@@ -3116,8 +3115,7 @@ compare_prepared_linux_kernel_packages(package& first_package,
return abigail::tools_utils::ABIDIFF_ERROR;
}
- if (!vmlinux_path2.empty()
- && !get_vmlinux_path_from_kernel_dist(debug_dir2, vmlinux_path2))
+ if (!get_vmlinux_path_from_kernel_dist(debug_dir2, vmlinux_path2))
{
emit_prefix("abipkgdiff", cerr)
<< "Could not find vmlinux in debuginfo package '"
--
2.39.1
next prev parent reply other threads:[~2023-03-07 18:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 15:50 [PATCH] tools-utils: Looks for vmlinux binary in RPM debug package Guillermo E. Martinez
2023-03-07 18:57 ` Guillermo E. Martinez [this message]
2023-03-08 14:34 ` Dodji Seketeli
2023-03-09 23:31 ` Guillermo E. Martinez
2023-03-10 7:49 ` Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230307185728.107659-1-guillermo.e.martinez@oracle.com \
--to=guillermo.e.martinez@oracle.com \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).