Re: [PATCH] tools-utils: Looks for vmlinux binary in RPM debug package

[Dodji Seketeli <dodji@seketeli.org>]

Hello,

[...]

> On Wed, Mar 08, 2023 at 03:34:24PM +0100, Dodji Seketeli wrote:

>> So, below is the resulting patch.
>> 
>> Could you please test it in your environment and tell me if it works for
>> you, the way you expect it?

"Guillermo E. Martinez" <guillermo.e.martinez@oracle.com> a écrit:

> Working as intended.

Dodji Seketeli <dodji@seketeli.org> a écrit:

[...]

> So, below is the resulting patch.

[...]

> From dc375bd1b7f15f41665f002ec61f68ce1e7ff889 Mon Sep 17 00:00:00 2001
> From: "Guillermo E. Martinez" <guillermo.e.martinez@oracle.com>
> Date: Mon, 6 Mar 2023 09:50:38 -0600
> Subject: [PATCH] tools-utils: Fix looking for vmlinux binary in debuginfo package
>
> When abipkgdiff is invoked on a `kernel' package,
> compare_prepared_linux_kernel_packages fails to look for the `vmlinux'
> file from the debuginfo package, because of a thinko.
>
> Then, build_corpus_group_from_kernel_dist_under, also fails to find
> `vmlinux' from the debuginfo package because of another thinko.
>
> This patch fixes the two thinkos.
>
> 	* src/abg-tools-utils.cc
> 	(get_binary_paths_from_kernel_dist): Fix a thinko and really use
> 	the kernel_modules_root variable.  Look for modules under
> 	kernel_modules_root and look for vmlinux (if necessary) under
> 	debug_info_root. Add comments.
> 	(compare_prepared_linux_kernel_packages): Fix another thinko.  Now
> 	we do have the path to vmlinux, from debuginfo packages before
> 	getting into get_binary_paths_from_kernel_dist.
>
> Signed-off-by: Guillermo E. Martinez <guillermo.e.martinez@oracle.com>
> Signed-off-by: Dodji Seketeli <dodji@redhat.com>

OK, I have just applied this patch to master.

Thank you for time and effort.  It's appreciated.

[...]

Cheers,

-- 
		Dodji