From: "Dmitry V. Levin" <ldv@strace.io>
To: libabigail@sourceware.org
Subject: [PATCH] elf-helpers: make sure config.h is included first
Date: Mon, 1 May 2023 23:20:07 +0300 [thread overview]
Message-ID: <20230501202007.GA30201@altlinux.org> (raw)
Before this change, verify-elf used to complain on x86 and armv7:
verify-elf: ERROR: ./usr/lib/libabigail.so.2.0.0: uses non-LFS functions: open
Include config.h in abg-elf-helpers.cc before other headers so that
AC_SYS_LARGEFILE applies to this file. This fully enables LFS
in those of 32-bit systems that do not enable it by default.
* src/abg-elf-helpers.cc: Include "config.h" first.
Fixes: 7bd69830520f ("Make Front Ends first class citizens")
Signed-off-by: Dmitry V. Levin <ldv@strace.io>
---
src/abg-elf-helpers.cc | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/abg-elf-helpers.cc b/src/abg-elf-helpers.cc
index d47c1c39..e05dccdc 100644
--- a/src/abg-elf-helpers.cc
+++ b/src/abg-elf-helpers.cc
@@ -6,6 +6,7 @@
/// @file
///
/// This contains the definitions of the ELF utilities for the dwarf reader.
+#include "config.h"
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
--
ldv
next reply other threads:[~2023-05-01 20:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-01 20:20 Dmitry V. Levin [this message]
2023-05-11 16:24 ` Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230501202007.GA30201@altlinux.org \
--to=ldv@strace.io \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).