From: Dodji Seketeli <dodji@seketeli.org>
To: "Dmitry V. Levin" <ldv@strace.io>
Cc: libabigail@sourceware.org
Subject: Re: [PATCH] elf-helpers: make sure config.h is included first
Date: Thu, 11 May 2023 18:24:37 +0200 [thread overview]
Message-ID: <87jzxedeey.fsf@seketeli.org> (raw)
In-Reply-To: <20230501202007.GA30201@altlinux.org> (Dmitry V. Levin's message of "Mon, 1 May 2023 23:20:07 +0300")
Hello Dmitry,
"Dmitry V. Levin" <ldv@strace.io> a écrit:
> Before this change, verify-elf used to complain on x86 and armv7:
> verify-elf: ERROR: ./usr/lib/libabigail.so.2.0.0: uses non-LFS functions: open
>
> Include config.h in abg-elf-helpers.cc before other headers so that
> AC_SYS_LARGEFILE applies to this file. This fully enables LFS
> in those of 32-bit systems that do not enable it by default.
>
> * src/abg-elf-helpers.cc: Include "config.h" first.
>
> Fixes: 7bd69830520f ("Make Front Ends first class citizens")
> Signed-off-by: Dmitry V. Levin <ldv@strace.io>
This looks good to me so I have applied to patch to the master branch
upstream.
Thanks a lot for your contribution.
[...]
Cheers,
--
Dodji
prev parent reply other threads:[~2023-05-12 8:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-01 20:20 Dmitry V. Levin
2023-05-11 16:24 ` Dodji Seketeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzxedeey.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=ldv@strace.io \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).