Re: [PATCH v2] ctf-reader: Add support to undefined forward declaration types

["Guillermo E. Martinez" <guillermo.e.martinez@oracle.com>]

On Friday, April 29, 2022 5:57:27 AM CDT Dodji Seketeli wrote:
> Hello,
Hello Dodji,

> "Guillermo E. Martinez via Libabigail" <libabigail@sourceware.org> a
> écrit:
> 
> [...]
> 
> > +static type_base_sptr
> > +process_ctf_forward_type(read_context *ctxt,
> > +                         corpus_sptr corp,
> > +                         translation_unit_sptr tunit,
> > +                         ctf_dict_t *ctf_dictionary,
> > +                         ctf_id_t ctf_type)
> 
> This function lacks a doxgen comment.  I have added it.
Thanks
> Also, the 'corp' parameter is not used in the body of the function.  So
> I have removed it.
great
> [...]
> 
> >  /// Build and return a struct type libabigail IR.
> >  ///
> >  /// @param ctxt the read context.
> > @@ -813,6 +860,12 @@ process_ctf_type(read_context *ctxt,
> >          result = is_type(struct_decl);
> >          break;
> >        }
> > +    case CTF_K_FORWARD:
> > +      {
> > +        result = process_ctf_forward_type(ctxt, corp, tunit, ctf_dictionary,
> > +                                          ctf_type);
> 
> I have updated this call to remove the "corp" parameter as it's not
> there anymore.
> > +      }
> > +      break;
> >      case CTF_K_UNION:
> >        {
> 
> [...]
> 
> > 	* src/abg-ctf-reader.cc (process_ctf_forward_type): New
> > 	function.
> > 	(process_ctf_type): New CTF_K_FORWARD case.
> > 	* tests/data/test-read-ctf/test-forward-undefine-type-decl.c:
> > 	New testcase.
> > 	* tests/data/test-read-ctf/test-forward-undefine-type-decl.abi:
> > 	New expected result.
> > 	* tests/data/test-read-ctf/test-forward-undefine-type-decl.o
> > 	New test input.
> > 	* tests/test-read-ctf.cc: Add new testcase to test harness.
> > 	* tests/data/Makefile.am: Add new test input files to test harness.
> >
> > Signed-off-by: Guillermo E. Martinez <guillermo.e.martinez@oracle.com>
> 
> Applying this to master, thanks!
Thanks!! :-)
> Cheers,
guillermo