From: Mark Wielaard <mark@klomp.org>
To: libabigail@sourceware.org
Subject: Re: [PATCH] DWARF reader: use size_t for more DWARF expression length
Date: Tue, 18 Jan 2022 14:14:16 +0100 [thread overview]
Message-ID: <498b857811cbb744b017c0d00b42dc07e375a7a9.camel@klomp.org> (raw)
In-Reply-To: <20220118130354.8649-1-mark@klomp.org>
Hi,
On Tue, 2022-01-18 at 14:03 +0100, Mark J. Wielaard wrote:
> From: Mark Wielaard <mark@klomp.org>
>
> commit 6e0d3f7 "DWARF reader: use size_t for DWARF expression
> length" is a partial fix for the assumption that size_t == uint64_t.
>
> This commit updates a couple more functions where this (wrong)
> assumption was made.
>
> * src/abg-dwarf-reader.cc (eval_last_constant_dwarf_sub_expr):
> Change expr_len argument type to size_t*.
> (op_pushes_constant_value): Change ops_len and index argument
> types to size_t; change next_index argument type to size_t&.
> (op_pushes_non_constant_value): Likewise.
> (op_is_arith_logic): Change expr_len and index argument
> types to size_t; change next_index argument type to size_t&.
> (op_is_control_flow): Likewise.
>
> Fixes: 16207c4af7bc ("Bug 28191 - Interpret DWARF 5 addrx locations")
> Signed-off-by: Mark Wielaard <mark@klomp.org>
Sorry, this is equivalent to Giuliano's patch in
https://sourceware.org/pipermail/libabigail/2022q1/004114.html
I was confused about was was/wasn't committed.
Cheers,
Mark
prev parent reply other threads:[~2022-01-18 13:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 13:03 Mark J. Wielaard
2022-01-18 13:14 ` Mark Wielaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498b857811cbb744b017c0d00b42dc07e375a7a9.camel@klomp.org \
--to=mark@klomp.org \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).