public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Fix leaf-mode formatting of decl <-> defn diffs.
@ 2020-06-16 12:12 Giuliano Procida
  2020-06-16 14:21 ` Dodji Seketeli
  0 siblings, 1 reply; 2+ messages in thread
From: Giuliano Procida @ 2020-06-16 12:12 UTC (permalink / raw)
  To: libabigail; +Cc: dodji, kernel-team, gprocida

This commit adds a missing newline.

	* src/abg-leaf-reporter.cc (leaf_reporter::report): In the
	class_or_union_diff overload, add a terminating new line after
	reporting a declaration-only <-> definition difference.

Signed-off-by: Giuliano Procida <gprocida@google.com>
---
 src/abg-leaf-reporter.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/abg-leaf-reporter.cc b/src/abg-leaf-reporter.cc
index b171d649..0b991cec 100644
--- a/src/abg-leaf-reporter.cc
+++ b/src/abg-leaf-reporter.cc
@@ -475,7 +475,7 @@ leaf_reporter::report(const class_or_union_diff& d,
 	  : " and is now a defined type";
 
 	out << indent << "type " << first->get_pretty_representation()
-	    << was << is_now;
+	    << was << is_now << "\n";
 	return;
       }
 
-- 
2.27.0.290.gba653c62da-goog


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix leaf-mode formatting of decl <-> defn diffs.
  2020-06-16 12:12 [PATCH] Fix leaf-mode formatting of decl <-> defn diffs Giuliano Procida
@ 2020-06-16 14:21 ` Dodji Seketeli
  0 siblings, 0 replies; 2+ messages in thread
From: Dodji Seketeli @ 2020-06-16 14:21 UTC (permalink / raw)
  To: Giuliano Procida; +Cc: libabigail, kernel-team

Giuliano Procida <gprocida@google.com> a écrit:

> This commit adds a missing newline.
>
> 	* src/abg-leaf-reporter.cc (leaf_reporter::report): In the
> 	class_or_union_diff overload, add a terminating new line after
> 	reporting a declaration-only <-> definition difference.
>
> Signed-off-by: Giuliano Procida <gprocida@google.com>

Applied to master, thanks!

Cheers,

-- 
		Dodji

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-06-16 14:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-16 12:12 [PATCH] Fix leaf-mode formatting of decl <-> defn diffs Giuliano Procida
2020-06-16 14:21 ` Dodji Seketeli

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).