* [PATCH] Tidy get_pretty_representation qualified_name.
@ 2020-05-05 18:17 Giuliano Procida
2020-05-13 8:04 ` Matthias Maennich
2020-05-14 14:34 ` Dodji Seketeli
0 siblings, 2 replies; 3+ messages in thread
From: Giuliano Procida @ 2020-05-05 18:17 UTC (permalink / raw)
To: libabigail; +Cc: dodji, kernel-team, gprocida
The virtual function get_pretty_representation exists in many
classes (derived from type_or_decl_base). It takes a qualified_name
argumenta and this is defaulted to true in all but one case which
seems to be an oversight.
This commit changes this for no better reason than consistency.
* include/abg-ir.h (type_decl::get_pretty_representation)
Change default for qualified_name parameter to true.
Signed-off-by: Giuliano Procida <gprocida@google.com>
---
include/abg-ir.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/abg-ir.h b/include/abg-ir.h
index fda10de5..edfea863 100644
--- a/include/abg-ir.h
+++ b/include/abg-ir.h
@@ -1920,7 +1920,7 @@ public:
virtual string
get_pretty_representation(bool internal = false,
- bool qualified_name = false) const;
+ bool qualified_name = true) const;
virtual bool
traverse(ir_node_visitor&);
--
2.26.2.526.g744177e7f7-goog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Tidy get_pretty_representation qualified_name.
2020-05-05 18:17 [PATCH] Tidy get_pretty_representation qualified_name Giuliano Procida
@ 2020-05-13 8:04 ` Matthias Maennich
2020-05-14 14:34 ` Dodji Seketeli
1 sibling, 0 replies; 3+ messages in thread
From: Matthias Maennich @ 2020-05-13 8:04 UTC (permalink / raw)
To: Giuliano Procida; +Cc: libabigail, dodji, kernel-team
On Tue, May 05, 2020 at 07:17:00PM +0100, Android Kernel Team wrote:
>The virtual function get_pretty_representation exists in many
>classes (derived from type_or_decl_base). It takes a qualified_name
>argumenta and this is defaulted to true in all but one case which
>seems to be an oversight.
>
>This commit changes this for no better reason than consistency.
>
> * include/abg-ir.h (type_decl::get_pretty_representation)
> Change default for qualified_name parameter to true.
>
>Signed-off-by: Giuliano Procida <gprocida@google.com>
Reviewed-by: Matthias Maennich <maennich@google.com>
Cheers,
Matthias
>---
> include/abg-ir.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/include/abg-ir.h b/include/abg-ir.h
>index fda10de5..edfea863 100644
>--- a/include/abg-ir.h
>+++ b/include/abg-ir.h
>@@ -1920,7 +1920,7 @@ public:
>
> virtual string
> get_pretty_representation(bool internal = false,
>- bool qualified_name = false) const;
>+ bool qualified_name = true) const;
>
> virtual bool
> traverse(ir_node_visitor&);
>--
>2.26.2.526.g744177e7f7-goog
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Tidy get_pretty_representation qualified_name.
2020-05-05 18:17 [PATCH] Tidy get_pretty_representation qualified_name Giuliano Procida
2020-05-13 8:04 ` Matthias Maennich
@ 2020-05-14 14:34 ` Dodji Seketeli
1 sibling, 0 replies; 3+ messages in thread
From: Dodji Seketeli @ 2020-05-14 14:34 UTC (permalink / raw)
To: Giuliano Procida; +Cc: libabigail, kernel-team
Giuliano Procida <gprocida@google.com> a écrit:
> The virtual function get_pretty_representation exists in many
> classes (derived from type_or_decl_base). It takes a qualified_name
> argumenta and this is defaulted to true in all but one case which
> seems to be an oversight.
>
> This commit changes this for no better reason than consistency.
>
> * include/abg-ir.h (type_decl::get_pretty_representation)
> Change default for qualified_name parameter to true.
>
> Signed-off-by: Giuliano Procida <gprocida@google.com>
Acked-by: Dodji Seketeli <dodji@seketeli.org>
Applied to master, thanks!
Cheers,
--
Dodji
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-14 14:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-05 18:17 [PATCH] Tidy get_pretty_representation qualified_name Giuliano Procida
2020-05-13 8:04 ` Matthias Maennich
2020-05-14 14:34 ` Dodji Seketeli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).