* [PATCH] Eliminate non-ASCII characters.
@ 2020-06-12 10:17 Giuliano Procida
2020-06-15 9:02 ` Dodji Seketeli
0 siblings, 1 reply; 2+ messages in thread
From: Giuliano Procida @ 2020-06-12 10:17 UTC (permalink / raw)
To: libabigail; +Cc: dodji, kernel-team, gprocida
There are few non-ASCII characters in various code comments. A few are
typos and the rest have obvious ASCII equivalents. This commit
replaces them all with ASCII characters.
* include/abg-diff-utils.h: Replace "’’" with "'".
* src/abg-elf-helpers.cc: Replace "⋅" with ".".
* src/abg-ini.cc: Replace "@êef" with "@ref".
* src/abg-ir.cc: Ditto.
* src/abg-tools-utils.cc: Replace "–" with "-".
Signed-off-by: Giuliano Procida <gprocida@google.com>
---
include/abg-diff-utils.h | 2 +-
src/abg-elf-helpers.cc | 2 +-
src/abg-ini.cc | 4 ++--
src/abg-ir.cc | 4 ++--
src/abg-tools-utils.cc | 2 +-
5 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/include/abg-diff-utils.h b/include/abg-diff-utils.h
index 8bc667d0..b59ffa04 100644
--- a/include/abg-diff-utils.h
+++ b/include/abg-diff-utils.h
@@ -1122,7 +1122,7 @@ is_match_point(RandomAccessOutputIterator a_begin,
/// section 4b in the paper. As the paper says, "The idea for doing
/// so is to simultaneously run the basic algorithm in both the
/// forward and reverse directions until furthest reaching forward and
-/// reverse paths starting at opposing corners ‘‘overlap’’."
+/// reverse paths starting at opposing corners 'overlap'."
///
/// @tparm RandomAccessOutputIterator the type of iterators passed to
/// this function. It must be a random access output iterator kind.
diff --git a/src/abg-elf-helpers.cc b/src/abg-elf-helpers.cc
index 02ecbcf2..ed768d22 100644
--- a/src/abg-elf-helpers.cc
+++ b/src/abg-elf-helpers.cc
@@ -895,7 +895,7 @@ is_linux_kernel(Elf *elf_handle)
|| is_linux_kernel_module(elf_handle));
}
-/// Get the address at which a given binary is loaded in memory⋅
+/// Get the address at which a given binary is loaded in memory.
///
/// @param elf_handle the elf handle for the binary to consider.
///
diff --git a/src/abg-ini.cc b/src/abg-ini.cc
index 1e5c11f3..5dc438b4 100644
--- a/src/abg-ini.cc
+++ b/src/abg-ini.cc
@@ -267,14 +267,14 @@ struct property_value::priv
/// Default constructor for the @ref property_value type.
///
-/// @param kind the of @êef property_value that is being constructed.
+/// @param kind the of @ref property_value that is being constructed.
property_value::property_value()
: priv_(new priv(ABSTRACT_PROPERTY_VALUE))
{}
/// Constructor for the @ref property_value type.
///
-/// @param kind the of @êef property_value that is being constructed.
+/// @param kind the of @ref property_value that is being constructed.
property_value::property_value(value_kind kind)
: priv_(new priv(kind))
{}
diff --git a/src/abg-ir.cc b/src/abg-ir.cc
index 5cc39f59..5e2506a2 100644
--- a/src/abg-ir.cc
+++ b/src/abg-ir.cc
@@ -12504,9 +12504,9 @@ integral_type::base_type
integral_type::get_base_type() const
{return base_;}
-/// Getter of the modifiers bitmap of the @êef integral_type.
+/// Getter of the modifiers bitmap of the @ref integral_type.
///
-/// @return the modifiers bitmap of the @êef integral_type.
+/// @return the modifiers bitmap of the @ref integral_type.
integral_type::modifiers_type
integral_type::get_modifiers() const
{return modifiers_;}
diff --git a/src/abg-tools-utils.cc b/src/abg-tools-utils.cc
index 11486a21..dfbec879 100644
--- a/src/abg-tools-utils.cc
+++ b/src/abg-tools-utils.cc
@@ -869,7 +869,7 @@ string_is_ascii(const string& str)
///
/// "if the hexadecimal value for a universal-character-name [...] or
/// string literal corresponds to a control character (in either of
-/// the ranges 0x00–0x1F or 0x7F–0x9F, both inclusive) [...] the
+/// the ranges 0x00-0x1F or 0x7F-0x9F, both inclusive) [...] the
/// program is ill-formed."
///
/// @param str the string to consider.
--
2.27.0.290.gba653c62da-goog
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Eliminate non-ASCII characters.
2020-06-12 10:17 [PATCH] Eliminate non-ASCII characters Giuliano Procida
@ 2020-06-15 9:02 ` Dodji Seketeli
0 siblings, 0 replies; 2+ messages in thread
From: Dodji Seketeli @ 2020-06-15 9:02 UTC (permalink / raw)
To: Giuliano Procida; +Cc: libabigail, kernel-team
Giuliano Procida <gprocida@google.com> a écrit:
> There are few non-ASCII characters in various code comments. A few are
> typos and the rest have obvious ASCII equivalents. This commit
> replaces them all with ASCII characters.
>
> * include/abg-diff-utils.h: Replace "’’" with "'".
> * src/abg-elf-helpers.cc: Replace "⋅" with ".".
> * src/abg-ini.cc: Replace "@êef" with "@ref".
> * src/abg-ir.cc: Ditto.
> * src/abg-tools-utils.cc: Replace "–" with "-".
>
> Signed-off-by: Giuliano Procida <gprocida@google.com>
Applied to master, thanks!
Cheers,
--
Dodji
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-15 9:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-12 10:17 [PATCH] Eliminate non-ASCII characters Giuliano Procida
2020-06-15 9:02 ` Dodji Seketeli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).