* [PATCH, applied] test-read-common: Fix error message
@ 2024-05-09 22:29 Dodji Seketeli
0 siblings, 0 replies; only message in thread
From: Dodji Seketeli @ 2024-05-09 22:29 UTC (permalink / raw)
To: libabigail
Hello,
The error message in test_task::run_abidw in test-read-common.cc is
wrong. Fixed thus. Also, emit the error message directly to the standard
error as the error is detected.
* tests/test-read-common.cc (test_task::run_abidw): Fix error
message and emit it to stderr directly.
Signed-off-by: Dodji Seketeli <dodji@redhat.com>
Applied to master branch.
---
tests/test-read-common.cc | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/tests/test-read-common.cc b/tests/test-read-common.cc
index 8c682b1c..9871f7c4 100644
--- a/tests/test-read-common.cc
+++ b/tests/test-read-common.cc
@@ -103,16 +103,12 @@ test_task::run_abidw(const string& extargs)
drop_private_types += "--headers-dir " + in_public_headers_path +
" --drop-private-types";
string cmd = abidw + " " + spec_options + drop_private_types +
- " --abidiff " + extargs + in_elf_path;
+ " --abidiff " + extargs + in_elf_path;
if (system(cmd.c_str()))
{
- error_message = string("ABIs differ:\n")
- + in_abi_path
- + "\nand:\n"
- + out_abi_path
- + "\n"
+ error_message = string("self comparison with abidw failed:\n")
+ "command was: '" + cmd + "'\n";
-
+ std::cerr << error_message;
return false;
}
--
2.39.3
--
Dodji
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-05-09 22:30 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-09 22:29 [PATCH, applied] test-read-common: Fix error message Dodji Seketeli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).