* [PATCH, applied] dwarf-reader: Make die_peel_{qual_ptr,typedef} always set peeled type
@ 2022-12-02 16:15 Dodji Seketeli
0 siblings, 0 replies; only message in thread
From: Dodji Seketeli @ 2022-12-02 16:15 UTC (permalink / raw)
To: libabigail
Hello,
When die_peel_{qual_ptr,typedef} don't actually peel anything, they
don't set the peeled type output argument. So callers expecting that
argument to be set can be surprised by the fact the peeled argument
might not be set.
* src/abg-dwarf-reader.cc (die_peel_qual_ptr, die_peel_typedef):
If the function returned true, then set the peeled argument even
if the function hasn't peeled anything.
Signed-off-by: Dodji Seketeli <dodji@redhat.com>
Applied to the master branch.
---
src/abg-dwarf-reader.cc | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/src/abg-dwarf-reader.cc b/src/abg-dwarf-reader.cc
index 5523d229..e18f111b 100644
--- a/src/abg-dwarf-reader.cc
+++ b/src/abg-dwarf-reader.cc
@@ -7136,6 +7136,8 @@ die_peel_qual_ptr(Dwarf_Die *die, Dwarf_Die& peeled_die)
else
return false;
+ memcpy(&peeled_die, die, sizeof(peeled_die));
+
while (tag == DW_TAG_const_type
|| tag == DW_TAG_volatile_type
|| tag == DW_TAG_restrict_type
@@ -7167,6 +7169,8 @@ die_peel_typedef(Dwarf_Die *die, Dwarf_Die& peeled_die)
int tag = dwarf_tag(die);
+ memcpy(&peeled_die, die, sizeof(peeled_die));
+
if (tag == DW_TAG_typedef)
{
if (!die_die_attribute(die, DW_AT_type, peeled_die))
--
2.31.1
--
Dodji
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-12-02 16:15 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-02 16:15 [PATCH, applied] dwarf-reader: Make die_peel_{qual_ptr,typedef} always set peeled type Dodji Seketeli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).