* [PATCH] ctf-reader: Fix missing initializer for member in test suite
@ 2022-12-22 15:49 Guillermo E. Martinez
2022-12-23 10:50 ` Dodji Seketeli
0 siblings, 1 reply; 2+ messages in thread
From: Guillermo E. Martinez @ 2022-12-22 15:49 UTC (permalink / raw)
To: libabigail; +Cc: Guillermo E. Martinez
Hello,
This patch is basically an amend for commit: 4cf2ef8f9754.
Apologies for it.
Kind regards,
guillermo
--
Compiler detects -Werror=missing-field-initializers in CTF test suite.
* tests/test-read-ctf.cc (in_out_specs): Add initializer for
`option' field in test entry.
* tests/data/test-read-ctf/test-alias.o.abi: Adjust.
Signed-off-by: Guillermo E. Martinez <guillermo.e.martinez@oracle.com>
---
tests/data/test-read-ctf/test-alias.o.abi | 4 ++--
tests/test-read-ctf.cc | 1 +
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/data/test-read-ctf/test-alias.o.abi b/tests/data/test-read-ctf/test-alias.o.abi
index b5fd92ad..0122abc6 100644
--- a/tests/data/test-read-ctf/test-alias.o.abi
+++ b/tests/data/test-read-ctf/test-alias.o.abi
@@ -8,8 +8,8 @@
<elf-symbol name='main_var' size='4' type='object-type' binding='global-binding' visibility='default-visibility' alias='alias_var' is-defined='yes'/>
</elf-variable-symbols>
<abi-instr address-size='64' language='LANG_C'>
- <type-decl name='int' size-in-bits='32' alignment-in-bits='32' id='type-id-1'/>
- <function-decl name='main_func' visibility='default' binding='global' size-in-bits='64' alignment-in-bits='8' elf-symbol-id='main_func'>
+ <type-decl name='int' size-in-bits='32' id='type-id-1'/>
+ <function-decl name='main_func' visibility='default' binding='global' size-in-bits='64' elf-symbol-id='main_func'>
<return type-id='type-id-2'/>
</function-decl>
<var-decl name='alias_var' type-id='type-id-1' mangled-name='alias_var' visibility='default' elf-symbol-id='alias_var'/>
diff --git a/tests/test-read-ctf.cc b/tests/test-read-ctf.cc
index f618e0fd..2dfdbf29 100644
--- a/tests/test-read-ctf.cc
+++ b/tests/test-read-ctf.cc
@@ -342,6 +342,7 @@ static InOutSpec in_out_specs[] =
SEQUENCE_TYPE_ID_STYLE,
"data/test-read-ctf/test-alias.o.abi",
"output/test-read-ctf/test-alias.o.abi",
+ "--ctf"
},
// CTF fallback feature.
{
--
2.35.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ctf-reader: Fix missing initializer for member in test suite
2022-12-22 15:49 [PATCH] ctf-reader: Fix missing initializer for member in test suite Guillermo E. Martinez
@ 2022-12-23 10:50 ` Dodji Seketeli
0 siblings, 0 replies; 2+ messages in thread
From: Dodji Seketeli @ 2022-12-23 10:50 UTC (permalink / raw)
To: Guillermo E. Martinez via Libabigail; +Cc: Guillermo E. Martinez
Hello Guillermo,
"Guillermo E. Martinez via Libabigail" <libabigail@sourceware.org> a
écrit:
[...]
> Compiler detects -Werror=missing-field-initializers in CTF test suite.
>
> * tests/test-read-ctf.cc (in_out_specs): Add initializer for
> `option' field in test entry.
> * tests/data/test-read-ctf/test-alias.o.abi: Adjust.
>
> Signed-off-by: Guillermo E. Martinez <guillermo.e.martinez@oracle.com>
Applied to master, thanks!
[...]
Cheers,
--
Dodji
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-23 10:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-22 15:49 [PATCH] ctf-reader: Fix missing initializer for member in test suite Guillermo E. Martinez
2022-12-23 10:50 ` Dodji Seketeli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).