From: Dodji Seketeli <dodji@seketeli.org>
To: "Matthias Männich" <maennich@google.com>
Cc: libabigail@sourceware.org, gprocida@google.com,
kernel-team@android.com
Subject: Re: [PATCH 2/2] symtab reader: fix symtab iterator to support C++20
Date: Wed, 07 Jun 2023 16:46:24 +0200 [thread overview]
Message-ID: <875y7zfhz3.fsf@seketeli.org> (raw)
In-Reply-To: <20230606085132.1894137-4-maennich@google.com> ("Matthias =?utf-8?Q?M=C3=A4nnich=22's?= message of "Tue, 6 Jun 2023 09:51:34 +0100")
"Matthias Männich" <maennich@google.com> a écrit:
> From: Matthias Maennich <maennich@google.com>
>
> Inheriting from std::vector::iterator causes the type to advertise
> itself as a contiguous iterator. This causes a compilation error in
> newer versions of libc++ that try to use contiguous-iterator-specific
> optimizations in those situations. Fixed thus by explicitly specifying
> the interator_concept tag.
>
> * abg-symtab-reader.h (symtab_iterator): Specify
> iterator_concept as forward_iterator to support C++20 compilation.
>
> Signed-off-by: Matthias Maennich <maennich@google.com>
Applied to master, thanks!
[...]
Cheers,
--
Dodji
next prev parent reply other threads:[~2023-06-07 14:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 8:51 [PATCH 1/2] symtab reader: use C++11 `using` syntax instead of typedefs Matthias Männich
2023-06-06 8:51 ` [PATCH 2/2] symtab reader: fix symtab iterator to support C++20 Matthias Männich
2023-06-07 6:53 ` Giuliano Procida
2023-06-07 14:46 ` Dodji Seketeli [this message]
2023-06-07 6:52 ` [PATCH 1/2] symtab reader: use C++11 `using` syntax instead of typedefs Giuliano Procida
2023-06-07 14:46 ` Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y7zfhz3.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).