public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: Dodji Seketeli <dodji@seketeli.org>
To: Giuliano Procida <gprocida@google.com>
Cc: libabigail@sourceware.org,  kernel-team@android.com,
	 maennich@google.com,  sidnayyar@google.com,  vvvvvv@google.com
Subject: Re: [PATCH v2] Narrow Linux symbol CRCs to 32 bits
Date: Thu, 17 Nov 2022 11:10:23 +0100	[thread overview]
Message-ID: <875yfdq4c0.fsf@seketeli.org> (raw)
In-Reply-To: <20221111132151.798754-1-gprocida@google.com> (Giuliano Procida's message of "Fri, 11 Nov 2022 13:21:51 +0000")

Hello Giuliano,

Giuliano Procida <gprocida@google.com> a écrit:

> MODVERSIONS CRCs are 32-bit hashes of strings representing C type
> elements or typed symbols. The hashes are calculated using a 32-bit
> CRC, hence the name. The kernel module loading code (implicitly)
> truncates any provided CRC value to 32 bits before comparing it with
> anything.
>
> When support was added to libabigail, values up to 64 bits wide were
> supported. This change narrows libabigail's concept of Linux CRC to 32
> bits. No tests are affected.
>
> 	* include/abg-ir.h (elf_symbol::elf_symbol): Change CRC type
> 	from optional<uint64_t> to optional<uint32_t>.
> 	(elf_symbol::create): Likewise.
> 	(elf_symbol::get_crc): Likewise.
> 	(elf_symbol::set_crc): Likewise.
> 	* src/abg-ir.cc (elf_symbol::priv) Change CRC type from
> 	optional<uint64_t> to optional<uint32_t>.
> 	(elf_symbol::priv::priv): Likewise.
> 	(elf_symbol::elf_symbol): Likewise.
> 	(elf_symbol::create): Likewise.
> 	(elf_symbol::get_crc): Likewise.
> 	(elf_symbol::set_crc): Likewise.
> 	* src/abg-reporter-priv.cc (maybe_report_diff_for_symbol):
> 	Change CRC type from optional<uint64_t> to
> 	optional<uint32_t>.
> 	* src/abg-symtab-reader.cc (symtab::load_): Change crc_values
> 	value type from uint64_t to uint32_t.

Applied to master, thanks!

[...]

Cheers,


-- 
		Dodji

      parent reply	other threads:[~2022-11-17 10:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-27 14:09 [PATCH] " Giuliano Procida
2022-10-27 15:53 ` Giuliano Procida
2022-10-28 15:13   ` Dodji Seketeli
2022-10-28 16:08     ` Giuliano Procida
2022-11-17 10:13       ` Dodji Seketeli
2022-11-11 13:21 ` [PATCH v2] " Giuliano Procida
2022-11-11 15:44   ` Giuliano Procida
2022-11-17 10:10   ` Dodji Seketeli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875yfdq4c0.fsf@seketeli.org \
    --to=dodji@seketeli.org \
    --cc=gprocida@google.com \
    --cc=kernel-team@android.com \
    --cc=libabigail@sourceware.org \
    --cc=maennich@google.com \
    --cc=sidnayyar@google.com \
    --cc=vvvvvv@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).