From: Dodji Seketeli <dodji@seketeli.org>
To: Giuliano Procida <gprocida@google.com>
Cc: libabigail@sourceware.org, kernel-team@android.com,
maennich@google.com
Subject: Re: [PATCH] XML writer: unify type emission tracking
Date: Tue, 07 Jun 2022 15:43:49 +0200 [thread overview]
Message-ID: <875ylcmvvu.fsf@seketeli.org> (raw)
In-Reply-To: <20220603130910.3039296-1-gprocida@google.com> (Giuliano Procida's message of "Fri, 3 Jun 2022 14:09:10 +0100")
Giuliano Procida <gprocida@google.com> a écrit:
> Empirically, the tracking of declaration-only type emission no longer
> seems to make any difference. It is removed here.
>
> * src/abg-writer.cc (write_context): Remove the
> m_emitted_decl_only_set member.
> (write_context::has_non_emitted_referenced_types): Remove the
> calls to decl_only_type_is_emitted.
> (write_context::record_decl_only_type_as_emitted): Removed.
> (write_context::decl_only_type_is_emitted): Ditto.
> (write_context::get_emitted_decl_only_types_set): Ditto.
> (referenced_type_should_be_emitted): Remove the calls to
> decl_only_type_is_emitted.
> (write_class_decl): Just call record_type_as_emitted.
> (write_union_decl): Ditto.
> (write_enum_type_decl): Not changed, but now all 3 functions
> have the same behaviour.
> (write_canonical_type_ids): Remove the call to
> get_emitted_decl_only_types_set.
>
> Signed-off-by: Giuliano Procida <gprocida@google.com>
Applied to master, thanks!
[...]
Cheers,
--
Dodji
prev parent reply other threads:[~2022-06-07 13:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 13:09 Giuliano Procida
2022-06-07 13:43 ` Dodji Seketeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875ylcmvvu.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).