From: Dodji Seketeli <dodji@seketeli.org>
To: "Jose E. Marchesi via Libabigail" <libabigail@sourceware.org>
Subject: Re: [PATCH] ctf: ctf_reader::read_corpus now sets a status
Date: Thu, 18 Nov 2021 09:49:50 +0100 [thread overview]
Message-ID: <875ysp6e6p.fsf@seketeli.org> (raw)
In-Reply-To: <20211116174307.23579-1-jose.marchesi@oracle.com> (Jose E. Marchesi via Libabigail's message of "Tue, 16 Nov 2021 18:43:07 +0100")
Hello,
[...]
"Jose E. Marchesi via Libabigail" <libabigail@sourceware.org> a écrit:
> diff --git a/src/abg-ctf-reader.cc b/src/abg-ctf-reader.cc
> index 27eddc2e..9cfa6cb7 100644
> --- a/src/abg-ctf-reader.cc
> +++ b/src/abg-ctf-reader.cc
> @@ -1073,19 +1073,28 @@ create_read_context(std::string elf_path, ir::environment *env)
> /// @return a shared pointer to the read corpus.
>
> corpus_sptr
> -read_corpus(read_context *ctxt)
> +read_corpus(read_context *ctxt, elf_reader::status &status)
> {
I have just added a comment to this function.
[...]
>
> * include/abg-ctf-reader.h: Include abg-elf-reader-common.h.
> read_corpus now gets an extra argument `status'.
> * src/abg-ctf-reader.cc (read_corpus): Likewise, and set `status'
> accordingly when the debug info is not found.
> * tools/abilint.cc (main): Pass a status argument to
> ctf_reader::read_corpus.
> * tools/abidiff.cc (main): Likewise.
>
> Signed-off-by: Jose E. Marchesi <jose.marchesi@oracle.com>
Applied to master.
Thanks!
Cheers,
--
Dodji
prev parent reply other threads:[~2021-11-18 8:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 17:43 Jose E. Marchesi
2021-11-18 8:49 ` Dodji Seketeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875ysp6e6p.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).