* [PATCH, applied] ir: Avoid canonicalizing types that are not meant to
@ 2021-10-18 8:50 Dodji Seketeli
0 siblings, 0 replies; only message in thread
From: Dodji Seketeli @ 2021-10-18 8:50 UTC (permalink / raw)
To: libabigail
[-- Attachment #1: Type: text/plain, Size: 8395 bytes --]
Hello,
hash_as_canonical_type_or_constant asserts that a certain number of
types are not meant to be canonicalized. We ought to make sure that
type_base::get_canonical_type_for always agrees with
hash_as_canonical_type_or_constant. This patch enforces that for
good measure.
* src/abg-ir.cc (type_base::get_canonical_type_for): Do not
canonicalize types that are not meant to.
(maybe_adjust_canonical_type): Do not crash when dealing with a
nil canonical type.
* tests/data/test-annotate/libtest23.so.abi: Adjust.
* tests/data/test-annotate/libtest24-drop-fns-2.so.abi: Likewise.
* tests/data/test-annotate/libtest24-drop-fns.so.abi: Likewise.
* tests/data/test-annotate/test-anonymous-members-0.o.abi: Likewise.
* tests/data/test-annotate/test0.abi: Likewise.
* tests/data/test-annotate/test1.abi: Likewise.
* tests/data/test-annotate/test13-pr18894.so.abi: Likewise.
* tests/data/test-annotate/test14-pr18893.so.abi: Likewise.
* tests/data/test-annotate/test15-pr18892.so.abi: Likewise.
* tests/data/test-annotate/test17-pr19027.so.abi: Likewise.
* tests/data/test-annotate/test18-pr19037-libvtkRenderingLIC-6.1.so.abi: Likewise.
* tests/data/test-annotate/test19-pr19023-libtcmalloc_and_profiler.so.abi: Likewise.
* tests/data/test-annotate/test2.so.abi: Likewise.
* tests/data/test-annotate/test20-pr19025-libvtkParallelCore-6.1.so.abi: Likewise.
* tests/data/test-annotate/test21-pr19092.so.abi: Likewise.
* tests/data/test-annotate/test3.so.abi: Likewise.
* tests/data/test-annotate/test5.o.abi: Likewise.
* tests/data/test-annotate/test8-qualified-this-pointer.so.abi: Likewise.
* tests/data/test-read-dwarf/PR22015-libboost_iostreams.so.abi: Likewise.
* tests/data/test-read-dwarf/PR22122-libftdc.so.abi: Likewise.
* tests/data/test-read-dwarf/PR24378-fn-is-not-scope.abi: Likewise.
* tests/data/test-read-dwarf/PR25007-sdhci.ko.abi: Likewise.
* tests/data/test-read-dwarf/PR25042-libgdbm-clang-dwarf5.so.6.0.0.abi: Likewise.
* tests/data/test-read-dwarf/PR26261/PR26261-exe.abi: Likewise.
* tests/data/test-read-dwarf/PR27700/test-PR27700.abi: Likewise.
* tests/data/test-read-dwarf/libtest23.so.abi: Likewise.
* tests/data/test-read-dwarf/libtest24-drop-fns-2.so.abi: Likewise.
* tests/data/test-read-dwarf/libtest24-drop-fns.so.abi: Likewise.
* tests/data/test-read-dwarf/test-PR26568-1.o.abi: Likewise.
* tests/data/test-read-dwarf/test-PR26568-2.o.abi: Likewise.
* tests/data/test-read-dwarf/test-libaaudio.so.abi: Likewise.
* tests/data/test-read-dwarf/test-libandroid.so.abi: Likewise.
* tests/data/test-read-dwarf/test-suppressed-alias.o.abi: Likewise.
* tests/data/test-read-dwarf/test0.abi: Likewise.
* tests/data/test-read-dwarf/test0.hash.abi: Likewise.
* tests/data/test-read-dwarf/test1.abi: Likewise.
* tests/data/test-read-dwarf/test1.hash.abi: Likewise.
* tests/data/test-read-dwarf/test10-pr18818-gcc.so.abi: Likewise.
* tests/data/test-read-dwarf/test11-pr18828.so.abi: Likewise.
* tests/data/test-read-dwarf/test12-pr18844.so.abi: Likewise.
* tests/data/test-read-dwarf/test13-pr18894.so.abi: Likewise.
* tests/data/test-read-dwarf/test14-pr18893.so.abi: Likewise.
* tests/data/test-read-dwarf/test15-pr18892.so.abi: Likewise.
* tests/data/test-read-dwarf/test16-pr18904.so.abi: Likewise.
* tests/data/test-read-dwarf/test17-pr19027.so.abi: Likewise.
* tests/data/test-read-dwarf/test18-pr19037-libvtkRenderingLIC-6.1.so.abi: Likewise.
* tests/data/test-read-dwarf/test19-pr19023-libtcmalloc_and_profiler.so.abi: Likewise.
* tests/data/test-read-dwarf/test2.so.abi: Likewise.
* tests/data/test-read-dwarf/test2.so.hash.abi: Likewise.
* tests/data/test-read-dwarf/test20-pr19025-libvtkParallelCore-6.1.so.abi: Likewise.
* tests/data/test-read-dwarf/test21-pr19092.so.abi: Likewise.
* tests/data/test-read-dwarf/test22-pr19097-libstdc++.so.6.0.17.so.abi: Likewise.
* tests/data/test-read-dwarf/test3-alias-1.so.hash.abi: Likewise.
* tests/data/test-read-dwarf/test3-alias-2.so.hash.abi: Likewise.
* tests/data/test-read-dwarf/test3-alias-3.so.hash.abi: Likewise.
* tests/data/test-read-dwarf/test3.so.abi: Likewise.
* tests/data/test-read-dwarf/test3.so.hash.abi: Likewise.
* tests/data/test-read-dwarf/test5.o.abi: Likewise.
* tests/data/test-read-dwarf/test5.o.hash.abi: Likewise.
* tests/data/test-read-dwarf/test8-qualified-this-pointer.so.abi: Likewise.
* tests/data/test-read-dwarf/test8-qualified-this-pointer.so.hash.abi: Likewise.
* tests/data/test-read-dwarf/test9-pr18818-clang.so.abi: Likewise.
Signed-off-by: Dodji Seketeli <dodji@redhat.com>
Applied to master.
---
src/abg-ir.cc | 9 +-
tests/data/test-annotate/libtest23.so.abi | 514 +-
.../test-annotate/libtest24-drop-fns-2.so.abi | 534 +-
.../test-annotate/libtest24-drop-fns.so.abi | 534 +-
.../test-anonymous-members-0.o.abi | 42 +-
tests/data/test-annotate/test0.abi | 44 +-
tests/data/test-annotate/test1.abi | 60 +-
.../data/test-annotate/test13-pr18894.so.abi | 2344 +-
.../data/test-annotate/test14-pr18893.so.abi | 4 +-
.../data/test-annotate/test15-pr18892.so.abi | 2037 +-
.../data/test-annotate/test17-pr19027.so.abi | 982 +-
...st18-pr19037-libvtkRenderingLIC-6.1.so.abi | 934 +-
...19-pr19023-libtcmalloc_and_profiler.so.abi | 4 +-
tests/data/test-annotate/test2.so.abi | 22 +-
...st20-pr19025-libvtkParallelCore-6.1.so.abi | 1486 +-
.../data/test-annotate/test21-pr19092.so.abi | 1494 +-
tests/data/test-annotate/test3.so.abi | 4 +-
tests/data/test-annotate/test5.o.abi | 4 +-
.../test8-qualified-this-pointer.so.abi | 14 +-
.../PR22015-libboost_iostreams.so.abi | 2032 +-
.../test-read-dwarf/PR22122-libftdc.so.abi | 3980 ++--
.../PR24378-fn-is-not-scope.abi | 12 +-
.../data/test-read-dwarf/PR25007-sdhci.ko.abi | 10243 +++++----
.../PR25042-libgdbm-clang-dwarf5.so.6.0.0.abi | 65 +-
.../test-read-dwarf/PR26261/PR26261-exe.abi | 2 +-
.../test-read-dwarf/PR27700/test-PR27700.abi | 2 +-
tests/data/test-read-dwarf/libtest23.so.abi | 506 +-
.../libtest24-drop-fns-2.so.abi | 528 +-
.../test-read-dwarf/libtest24-drop-fns.so.abi | 486 +-
.../data/test-read-dwarf/test-PR26568-1.o.abi | 22 +-
.../data/test-read-dwarf/test-PR26568-2.o.abi | 18 +-
.../test-read-dwarf/test-libaaudio.so.abi | 2 +-
.../test-read-dwarf/test-libandroid.so.abi | 2 +-
.../test-suppressed-alias.o.abi | 2 +-
tests/data/test-read-dwarf/test0.abi | 42 +-
tests/data/test-read-dwarf/test0.hash.abi | 2 +-
tests/data/test-read-dwarf/test1.abi | 58 +-
tests/data/test-read-dwarf/test1.hash.abi | 2 +-
.../test-read-dwarf/test10-pr18818-gcc.so.abi | 606 +-
.../test-read-dwarf/test11-pr18828.so.abi | 2054 +-
.../test-read-dwarf/test12-pr18844.so.abi | 18112 ++++++++--------
.../test-read-dwarf/test13-pr18894.so.abi | 2138 +-
.../test-read-dwarf/test14-pr18893.so.abi | 2 +-
.../test-read-dwarf/test15-pr18892.so.abi | 2020 +-
.../test-read-dwarf/test16-pr18904.so.abi | 2 +-
.../test-read-dwarf/test17-pr19027.so.abi | 980 +-
...st18-pr19037-libvtkRenderingLIC-6.1.so.abi | 932 +-
...19-pr19023-libtcmalloc_and_profiler.so.abi | 2 +-
tests/data/test-read-dwarf/test2.so.abi | 20 +-
tests/data/test-read-dwarf/test2.so.hash.abi | 2 +-
...st20-pr19025-libvtkParallelCore-6.1.so.abi | 1484 +-
.../test-read-dwarf/test21-pr19092.so.abi | 1492 +-
.../test22-pr19097-libstdc++.so.6.0.17.so.abi | 2 +-
.../test-read-dwarf/test3-alias-1.so.hash.abi | 2 +-
.../test-read-dwarf/test3-alias-2.so.hash.abi | 2 +-
.../test-read-dwarf/test3-alias-3.so.hash.abi | 2 +-
tests/data/test-read-dwarf/test3.so.abi | 2 +-
tests/data/test-read-dwarf/test3.so.hash.abi | 2 +-
tests/data/test-read-dwarf/test5.o.abi | 2 +-
tests/data/test-read-dwarf/test5.o.hash.abi | 2 +-
.../test8-qualified-this-pointer.so.abi | 12 +-
.../test8-qualified-this-pointer.so.hash.abi | 2 +-
.../test9-pr18818-clang.so.abi | 1634 +-
63 files changed, 30486 insertions(+), 30096 deletions(-)
The patch is too big for the mailing list so I am attaching it in a
zipped form.
[-- Attachment #2: Zipped patch --]
[-- Type: application/gzip, Size: 669551 bytes --]
[-- Attachment #3: Type: text/plain, Size: 13 bytes --]
--
Dodji
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-10-18 8:51 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-18 8:50 [PATCH, applied] ir: Avoid canonicalizing types that are not meant to Dodji Seketeli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).