Re: [PATCH] Fix declaratons of conditionally defined functions

[Dodji Seketeli <dodji@seketeli.org>]

Hello Ben,

Ben Woodard via Libabigail <libabigail@sourceware.org> a écrit:

> Functions relating to zip archives are declared but are never compiled
> when --enable-zip-archive=no, the default.
>
> This makes sure that they are not declared when they won't be defined
> due to conditional compilation.
>
> Signed-off-by: Ben Woodard <woodard@redhat.com>

I have amended the commit log to add the ChangeLog part as explained in
the document
https://sourceware.org/git/?p=libabigail.git;a=blob;f=COMMIT-LOG-GUIDELINES.

So here is what the adjusted commit log looks like:

Functions relating to zip archives are declared but are never compiled
when --enable-zip-archive=no, the default.

This makes sure that they are not declared when they won't be defined
due to conditional compilation.

	* include/abg-reader.h (read_corpus_from_file): Guard the
	declaration of these overloads with #ifdef WITH_ZIP_ARCHIVE.
	* tools/abilint.cc: Guard the use of
	abigail::xml_reader::read_corpus_from_file with #ifdef
	WITH_ZIP_ARCHIVE.

Other than that, the patch looks good to me and I have applied to
master.

Thanks!

[...]

Cheers,

-- 
		Dodji