From: Dodji Seketeli <dodji@seketeli.org>
To: Giuliano Procida <gprocida@google.com>
Cc: libabigail@sourceware.org, kernel-team@android.com,
maennich@google.com
Subject: Re: [PATCH] abidiff: include ABI XML versions when reporting a mismatch
Date: Tue, 18 Jan 2022 17:13:30 +0100 [thread overview]
Message-ID: <877daxc991.fsf@seketeli.org> (raw)
In-Reply-To: <20220118090315.854147-1-gprocida@google.com> (Giuliano Procida's message of "Tue, 18 Jan 2022 09:03:15 +0000")
Giuliano Procida <gprocida@google.com> a écrit:
> In the rare event of an XML version mismatch it would be helpful to
> have the versions in the error message, particularly if abidiff is
> being run from automation.
>
> * tools/abidiff.cc
> (emit_incompatible_format_version_error_message): Add version1
> and version2 arguments. Add versions to error message.
> (main): Pass emit_incompatible_format_version_error_message
> mismatching versions.
>
> Signed-off-by: Giuliano Procida <gprocida@google.com>
Applied to master branch, thanks!
[...]
Cheers,
--
Dodji
prev parent reply other threads:[~2022-01-18 16:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 9:03 Giuliano Procida
2022-01-18 16:13 ` Dodji Seketeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877daxc991.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).