* [PATCH] abg-ir.cc: Remove duplicated line of code
@ 2020-07-17 14:29 Giuliano Procida
2020-07-28 16:53 ` Dodji Seketeli
0 siblings, 1 reply; 2+ messages in thread
From: Giuliano Procida @ 2020-07-17 14:29 UTC (permalink / raw)
To: libabigail; +Cc: dodji, kernel-team, gprocida
The commit
dbef379a Support incomplete enums in core and diff code.
added a duplicated line of code in error. This commit removes it.
* src/abg-ir.cc (decl_base::set_definition_of_declaration):
Remove duplicated assignment statement.
Signed-off-by: Giuliano Procida <gprocida@google.com>
---
src/abg-ir.cc | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/abg-ir.cc b/src/abg-ir.cc
index 757605f8..f91c42df 100644
--- a/src/abg-ir.cc
+++ b/src/abg-ir.cc
@@ -12301,7 +12301,6 @@ decl_base::set_definition_of_declaration(const decl_base_sptr& d)
{
ABG_ASSERT(get_is_declaration_only());
priv_->definition_of_declaration_ = d;
- priv_->definition_of_declaration_ = d;
if (type_base *t = is_type(this))
if (type_base_sptr canonical_type = is_type(d)->get_canonical_type())
t->priv_->canonical_type = canonical_type;
--
2.28.0.rc0.105.gf9edc3c819-goog
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] abg-ir.cc: Remove duplicated line of code
2020-07-17 14:29 [PATCH] abg-ir.cc: Remove duplicated line of code Giuliano Procida
@ 2020-07-28 16:53 ` Dodji Seketeli
0 siblings, 0 replies; 2+ messages in thread
From: Dodji Seketeli @ 2020-07-28 16:53 UTC (permalink / raw)
To: Giuliano Procida; +Cc: libabigail, kernel-team
Giuliano Procida <gprocida@google.com> a écrit:
> The commit
>
> dbef379a Support incomplete enums in core and diff code.
>
> added a duplicated line of code in error. This commit removes it.
>
> * src/abg-ir.cc (decl_base::set_definition_of_declaration):
> Remove duplicated assignment statement.
>
> Signed-off-by: Giuliano Procida <gprocida@google.com>
Applied to master, thanks!
Cheers,
--
Dodji
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-28 16:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-17 14:29 [PATCH] abg-ir.cc: Remove duplicated line of code Giuliano Procida
2020-07-28 16:53 ` Dodji Seketeli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).