public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: Dodji Seketeli <dodji@seketeli.org>
To: Ben Woodard via Libabigail <libabigail@sourceware.org>
Subject: Re: [PATCH] Trivial: Add missing space
Date: Tue, 07 Jun 2022 15:17:19 +0200	[thread overview]
Message-ID: <87a6aomx40.fsf@seketeli.org> (raw)
In-Reply-To: <20220603124646.315022-1-woodard@redhat.com> (Ben Woodard via Libabigail's message of "Fri, 3 Jun 2022 05:46:46 -0700")

Ben Woodard via Libabigail <libabigail@sourceware.org> a écrit:

> This is absolutely trivial but I noticed this missing space one day
> and fixed it and have been carrying the hunk of patch for months.
>
>     	* tools/abicompat.cc - add missing space in expression.

Thanks, I have applied this to master.

I have just amdended the ChangeLog part of the log to make it comply
with the standard.

Here is the applied patch.

From bb935f62197532b35bb2d63c4f7cd532a7d91d57 Mon Sep 17 00:00:00 2001
From: Ben Woodard <woodard@redhat.com>
Date: Fri, 3 Jun 2022 05:46:46 -0700
Subject: [PATCH] abicompat: Add missing space

This is absolutely trivial but I noticed this missing space one day
and fixed it and have been carrying the hunk of patch for months.

	* tools/abicompat.cc (main): Add missing space in expression.

Signed-off-by: Ben Woodard <woodard@redhat.com>
Signed-off-by: Dodji Seketeli <dodji@redhat.com>
---
 tools/abicompat.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/abicompat.cc b/tools/abicompat.cc
index f4bc384d..913724c7 100644
--- a/tools/abicompat.cc
+++ b/tools/abicompat.cc
@@ -691,7 +691,7 @@ main(int argc, char* argv[])
   suppressions_type& supprs = ctxt->suppressions();
   bool files_suppressed = (file_is_suppressed(opts.app_path, supprs)
 			   || file_is_suppressed(opts.lib1_path, supprs)
-			   ||file_is_suppressed(opts.lib2_path, supprs));
+			   || file_is_suppressed(opts.lib2_path, supprs));
 
   if (files_suppressed)
     // We don't have to compare anything because a user
-- 
2.36.1


-- 
		Dodji

      reply	other threads:[~2022-06-07 13:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-03 12:46 Ben Woodard
2022-06-07 13:17 ` Dodji Seketeli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6aomx40.fsf@seketeli.org \
    --to=dodji@seketeli.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).