[libabigail][PATCH v2] Fix trivial typo when printing help information

[libabigail][PATCH v2] Fix trivial typo when printing help information

[tangmeng]

When abicompat prints its help information, it does not terminate
it with a newline and option format is not aligned the way that
other commands do.

Signed-off-by: tangmeng <tangmeng@uniontech.com>
---
 tools/abicompat.cc | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/tools/abicompat.cc b/tools/abicompat.cc
index be3946e1..60cd794f 100644
--- a/tools/abicompat.cc
+++ b/tools/abicompat.cc
@@ -105,12 +105,12 @@ display_usage(const string& prog_name, ostream& out)
     "to the debug information directory for the first library\n"
     << "  --lib-debug-info-dir2|--libd2 <path-to-lib-debug-info2>  set the path "
     "to the debug information directory for the second library\n"
-    <<  "--suppressions|--suppr <path> specify a suppression file\n"
-    << "--no-redundant  do not display redundant changes\n"
-    << "--no-show-locs  do now show location information\n"
-    << "--redundant  display redundant changes (this is the default)\n"
-    << "--weak-mode  check compatibility between the application and "
-    "just one version of the library."
+    << "  --suppressions|--suppr <path> specify a suppression file\n"
+    << "  --no-redundant  do not display redundant changes\n"
+    << "  --no-show-locs  do now show location information\n"
+    << "  --redundant  display redundant changes (this is the default)\n"
+    << "  --weak-mode  check compatibility between the application and "
+    "just one version of the library.\n"
     ;
 }
 
-- 
2.20.1

Re: [libabigail][PATCH v2] Fix trivial typo when printing help information

[Dodji Seketeli]

Hello,

Thank you for the patch!

It looks good to me so I have applied to the master branch of the Git
repository.

I have just amended the git commit log to format it as described in the
COMMIT-LOG-GUIDELINES file, available in the source at
https://sourceware.org/git/?p=libabigail.git;a=blob_plain;f=COMMIT-LOG-GUIDELINES;hb=HEAD.

I am attaching below what has been committed.

Thanks again!

commit 5c67169668831a73160ffc5fbf330d0854182c8c
Author: tangmeng <tangmeng@uniontech.com>
Date:   Wed Oct 27 11:44:24 2021 +0800

    Fix trivial typo when printing help information
    
    When abicompat prints its help information, it does not terminate
    it with a newline and option format is not aligned the way that
    other commands do.
    
            * tools/abicompat.cc (display_usage): End the usage message with a
            newline and properly indent it.
    
    Signed-off-by: tangmeng <tangmeng@uniontech.com>
    Signed-off-by: Dodji Seketeli <dodji@redhat.com>

diff --git a/tools/abicompat.cc b/tools/abicompat.cc
index be3946e1..60cd794f 100644
--- a/tools/abicompat.cc
+++ b/tools/abicompat.cc
@@ -105,12 +105,12 @@ display_usage(const string& prog_name, ostream& out)
     "to the debug information directory for the first library\n"
     << "  --lib-debug-info-dir2|--libd2 <path-to-lib-debug-info2>  set the path "
     "to the debug information directory for the second library\n"
-    <<  "--suppressions|--suppr <path> specify a suppression file\n"
-    << "--no-redundant  do not display redundant changes\n"
-    << "--no-show-locs  do now show location information\n"
-    << "--redundant  display redundant changes (this is the default)\n"
-    << "--weak-mode  check compatibility between the application and "
-    "just one version of the library."
+    << "  --suppressions|--suppr <path> specify a suppression file\n"
+    << "  --no-redundant  do not display redundant changes\n"
+    << "  --no-show-locs  do now show location information\n"
+    << "  --redundant  display redundant changes (this is the default)\n"
+    << "  --weak-mode  check compatibility between the application and "
+    "just one version of the library.\n"
     ;
 }
 

-- 
		Dodji