* [PATCH, applied] ir: Fix canonical type propagation cancelling
@ 2021-09-08 14:24 Dodji Seketeli
0 siblings, 0 replies; only message in thread
From: Dodji Seketeli @ 2021-09-08 14:24 UTC (permalink / raw)
To: libabigail
Hello,
During the canonical type propagation optimization, when the
comparison of two type sub-objects fails, we need to cancel the
(potential) propagation of the canonical type of the current type
sub-object being compared.
We were not doing that in return_comparison_result, but were expecting
it. Oops.
Fixed thus.
This helps to fix bug https://bugzilla.redhat.com/show_bug.cgi?id=1951501.
* src/abg-ir.cc (return_comparison_result): When the comparison of
the current type sub-object fails, clear the potentially
propagated canonical type and remove it from the set of types with
non confirmed propagated canonical types.
Signed-off-by: Dodji Seketeli <dodji@redhat.com>
Applied to master.
---
src/abg-ir.cc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/abg-ir.cc b/src/abg-ir.cc
index a12a6955..3ce49e76 100644
--- a/src/abg-ir.cc
+++ b/src/abg-ir.cc
@@ -1005,12 +1005,12 @@ return_comparison_result(T& l, T& r, bool value)
{
// The right-hand-side operand cannot carry any tentative
// canonical type at this point.
- type_base* canonical_type = r.get_naked_canonical_type();
- ABG_ASSERT(canonical_type == nullptr);
+ is_type(&r)->priv_->clear_propagated_canonical_type();
// Reset the marking of the right-hand-side operand as it no
// longer carries a tentative canonical type that might be
// later cancelled.
is_type(&r)->priv_->set_does_not_depend_on_recursive_type();
+ env->priv_->remove_from_types_with_non_confirmed_propagated_ct(&r);
}
}
}
--
2.30.0
--
Dodji
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-09-08 14:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-08 14:24 [PATCH, applied] ir: Fix canonical type propagation cancelling Dodji Seketeli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).