From: Dodji Seketeli <dodji@seketeli.org>
To: Giuliano Procida <gprocida@google.com>
Cc: libabigail@sourceware.org, kernel-team@android.com,
maennich@google.com, sidnayyar@google.com, vvvvvv@google.com
Subject: Re: [PATCH] DWARF reader: avoid C++20 operator!= overload ambiguity
Date: Mon, 09 Jan 2023 17:03:15 +0100 [thread overview]
Message-ID: <87cz7nlmpo.fsf@seketeli.org> (raw)
In-Reply-To: <20230109092044.787665-1-gprocida@google.com> (Giuliano Procida's message of "Mon, 9 Jan 2023 09:20:44 +0000")
Hello Giuliano,
First of all, Happy New Year to you and your beloved ones!
Giuliano Procida <gprocida@google.com> a écrit:
> C++20 automatically generates overloads for certain comparison
> operators based on others and this can create ambiguity with older
> code. The type expr_result has various operators defined and comparing
> expr_result != int becomes ambiguous.
>
> This change just avoids this comparison by extracting the underlying
> value, rather than making changes to the type itself. There should be
> no change in behaviour and no tests are affected.
>
> * (src/abg-dwarf-reader.cc) op_is_control_flow: In the
> DW_OP_bra case, when testing the popped value, use the
> expr_result's const_value explicitly.
>
> Signed-off-by: Giuliano Procida <gprocida@google.com>
Applied to the master branch, thanks!
[...]
Cheers,
--
Dodji
prev parent reply other threads:[~2023-01-09 16:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 9:20 Giuliano Procida
2023-01-09 16:03 ` Dodji Seketeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cz7nlmpo.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
--cc=sidnayyar@google.com \
--cc=vvvvvv@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).