From: Dodji Seketeli <dodji@seketeli.org>
To: Ben Woodard via Libabigail <libabigail@sourceware.org>
Cc: Ben Woodard <woodard@redhat.com>,
vsoch <vsoch@users.noreply.github.com>
Subject: Re: [PATCH] V2 Add Logic to detect file type by extension
Date: Thu, 12 May 2022 12:12:48 +0200 [thread overview]
Message-ID: <87czgjvz33.fsf@seketeli.org> (raw)
In-Reply-To: <20220504195137.1790994-1-woodard@redhat.com> (Ben Woodard via Libabigail's message of "Wed, 4 May 2022 12:51:38 -0700")
Ben Woodard via Libabigail <libabigail@sourceware.org> a écrit:
> From: vsoch <vsoch@users.noreply.github.com>
>
> Changes since V1
> Merge in the correct version of the patch not an early diagnostic
> one.
>
> Fedabipkgdiff uses mimetypes to detect what file type it is looking
> at. In some minimal versions of the OS, in particular container
> images, the package that includes all the mimetypes may not be
> installed. This allows fedabipkgdiff to fall back to using the
> extension.
>
> * tools/fedabipkgdiff - add logic to detect file type by extension
>
> Signed-off-by: vsoch <vsoch@users.noreply.github.com>
> Reviewed-by: Ben Woodard <woodard@redhat.com>
Applied to master, thanks!
Cheers,
--
Dodji
prev parent reply other threads:[~2022-05-16 14:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 19:51 Ben Woodard
2022-05-12 10:12 ` Dodji Seketeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czgjvz33.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=libabigail@sourceware.org \
--cc=vsoch@users.noreply.github.com \
--cc=woodard@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).