public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
* [PATCH, applied] Miscellaneous indentation and comments cleanups
@ 2021-05-25  9:38 Dodji Seketeli
  0 siblings, 0 replies; only message in thread
From: Dodji Seketeli @ 2021-05-25  9:38 UTC (permalink / raw)
  To: libabigail

Hello,

While looking at something else, I did some indentation and comments cleanups.

	* src/abg-ir.cc (environment::priv::{config_, canonical_types_,
	sorted_canonical_types_, void_type_, variadic_marker_type_}):
	Re-indent these data members.
	(peel_typedef_pointer_or_reference_type): Fix comment.
	(var_decl::var_decl): Likewise.
	(function_decl::function_decl): Add a comment.
	* src/abg-reader.cc (handle_reference_type_def): Fix indentation
	of parameters.

Signed-off-by: Dodji Seketeli <dodji@redhat.com>

Applied to master.

---
 src/abg-ir.cc     | 33 ++++++++++++++++++++++++---------
 src/abg-reader.cc |  4 ++--
 2 files changed, 26 insertions(+), 11 deletions(-)

diff --git a/src/abg-ir.cc b/src/abg-ir.cc
index 2ad7910b..85766edf 100644
--- a/src/abg-ir.cc
+++ b/src/abg-ir.cc
@@ -2776,11 +2776,11 @@ typedef unordered_map<interned_string,
 /// The private data of the @ref environment type.
 struct environment::priv
 {
-  config			 config_;
-  canonical_types_map_type	 canonical_types_;
-  mutable vector<type_base_sptr> sorted_canonical_types_;
-  type_base_sptr		 void_type_;
-  type_base_sptr		 variadic_marker_type_;
+  config				config_;
+  canonical_types_map_type		canonical_types_;
+  mutable vector<type_base_sptr>	sorted_canonical_types_;
+  type_base_sptr			void_type_;
+  type_base_sptr			variadic_marker_type_;
   unordered_set<const class_or_union*>	classes_being_compared_;
   unordered_set<const function_type*>	fn_types_being_compared_;
   vector<type_base_sptr>	 extra_live_types_;
@@ -6061,8 +6061,8 @@ peel_qualified_or_typedef_type(const type_base_sptr &t)
 }
 
 /// Return the leaf underlying or pointed-to type node of a @ref
-/// typedef_decl, @ref pointer_type_def or @ref reference_type_def
-/// node.
+/// typedef_decl, @ref pointer_type_def, @ref reference_type_def,
+/// or @ref array_type_def node.
 ///
 /// @param type the type to peel.
 ///
@@ -16465,11 +16465,11 @@ struct var_decl::priv
   {}
 }; // end struct var_decl::priv
 
-/// Constructor
+/// Constructor of the @ref var_decl type.
 ///
 /// @param name the name of the variable declaration
 ///
-/// @param name the type of the variable declaration
+/// @param type the type of the variable declaration
 ///
 /// @param locus the source location where the variable was defined.
 ///
@@ -17745,6 +17745,21 @@ struct function_decl::priv
   {}
 }; // end sruct function_decl::priv
 
+/// Constructor of the @ref function_decl.
+///
+/// @param name the name of the function.
+///
+/// @param function_type the type of the function.
+///
+/// @param declared_inline wether the function is declared inline.
+///
+/// @param locus the source location of the function.
+///
+/// @param mangled_name the linkage name of the function.
+///
+/// @param vis the visibility of the function.
+///
+/// @param bind the binding of the function.
 function_decl::function_decl(const string& name,
 			     function_type_sptr function_type,
 			     bool declared_inline,
diff --git a/src/abg-reader.cc b/src/abg-reader.cc
index 39629314..05f1a6fa 100644
--- a/src/abg-reader.cc
+++ b/src/abg-reader.cc
@@ -5625,11 +5625,11 @@ handle_reference_type_def(read_context& ctxt,
 /// function_type is added to.
 static type_base_sptr
 handle_function_type(read_context&	ctxt,
-		     xmlNodePtr		node,
+		     xmlNodePtr	node,
 		     bool		add_to_current_scope)
 {
   function_type_sptr type = build_function_type(ctxt, node,
-						add_to_current_scope);
+						  add_to_current_scope);
   ctxt.maybe_canonicalize_type(type, /*force_delay=*/true);
   return type;
 }
-- 
2.30.0


-- 
		Dodji


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-05-25  9:38 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-25  9:38 [PATCH, applied] Miscellaneous indentation and comments cleanups Dodji Seketeli

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).