From: Dodji Seketeli <dodji@redhat.com>
To: libabigail@sourceware.org
Cc: gprocida@google.com, Dodji Seketeli <dodji@redhat.com>
Subject: [PATCH 1/4] fe-iface: Add missing virtual destructor
Date: Fri, 03 Feb 2023 12:47:23 +0100 [thread overview]
Message-ID: <87fsbnt1h0.fsf_-_@redhat.com> (raw)
In-Reply-To: <87mt5vt3op.fsf@seketeli.org> (Dodji Seketeli's message of "Fri, 03 Feb 2023 11:59:34 +0100")
Hello,
* include/abg-fe-iface.cc (fe_iface::~fe_iface): Make this
virtual.
Signed-off-by: Dodji Seketeli <dodji@redhat.com>
---
include/abg-fe-iface.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/abg-fe-iface.h b/include/abg-fe-iface.h
index d83a1391..12b8b2bd 100644
--- a/include/abg-fe-iface.h
+++ b/include/abg-fe-iface.h
@@ -72,7 +72,7 @@ protected:
fe_iface(const std::string& corpus_path, environment& e);
- ~fe_iface();
+ virtual ~fe_iface();
void
reset(const std::string& corpus_path, environment& e);
--
2.31.1
--
Dodji
next prev parent reply other threads:[~2023-02-03 11:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 10:48 [PATCH, RFC] {dwarf,elf_based}-reader,writer: Avoid duplicating corpora in corpus_group Dodji Seketeli
2023-02-03 10:59 ` [PATCH 0/4] Fix duplicated corpora in corpus group Dodji Seketeli
2023-02-03 11:47 ` Dodji Seketeli [this message]
2023-02-03 11:47 ` [PATCH 2/4] dwarf-reader: Remove unused code Dodji Seketeli
2023-02-03 11:48 ` [PATCH 3/4] corpus: Handle empty symbol table cases Dodji Seketeli
2023-02-03 11:49 ` [PATCH 4/4] {dwarf,elf_based}-reader,writer: Avoid duplicating corpora in corpus_group Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsbnt1h0.fsf_-_@redhat.com \
--to=dodji@redhat.com \
--cc=gprocida@google.com \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).