public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: Dodji Seketeli <dodji@seketeli.org>
To: libabigail@sourceware.org
Cc: gprocida@google.com, Dodji Seketeli <dodji@redhat.com>
Subject: [PATCH 0/4] Fix duplicated corpora in corpus group
Date: Fri, 03 Feb 2023 11:59:34 +0100	[thread overview]
Message-ID: <87mt5vt3op.fsf@seketeli.org> (raw)
In-Reply-To: <878rhh8xwb.fsf@redhat.com> (Dodji Seketeli via Libabigail's message of "Wed, 01 Feb 2023 11:48:04 +0100")

Hello,

Giuliano Procida brought to my attention that the ABI representation
emitted by abidw from current mainline wrongly duplicates every single
corpus in a corpus group represented in the ABIXML output.

The last patch of this series fixes the issue.

While testing that patch however, Giuliano noted other unrelated
issues with the code base.  The first three patches of the series
address those lateral problems.

This series is applied to the mainline.

Dodji Seketeli (4):
  fe-iface: Add missing virtual destructor
  dwarf-reader: Remove unused code
  corpus: Handle empty symbol table cases
  {dwarf,elf_based}-reader,writer: Avoid duplicating corpora in corpus_group

 include/abg-fe-iface.h      |  2 +-
 src/abg-corpus.cc           | 58 +++++++++++++++++++++++++------------
 src/abg-dwarf-reader.cc     | 44 ----------------------------
 src/abg-elf-based-reader.cc |  4 +--
 src/abg-writer.cc           | 45 ++++++++++++++++++++++++++--
 5 files changed, 85 insertions(+), 68 deletions(-)

-- 
2.31.1



-- 
		Dodji

  reply	other threads:[~2023-02-03 10:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-01 10:48 [PATCH, RFC] {dwarf,elf_based}-reader,writer: Avoid duplicating corpora in corpus_group Dodji Seketeli
2023-02-03 10:59 ` Dodji Seketeli [this message]
2023-02-03 11:47   ` [PATCH 1/4] fe-iface: Add missing virtual destructor Dodji Seketeli
2023-02-03 11:47   ` [PATCH 2/4] dwarf-reader: Remove unused code Dodji Seketeli
2023-02-03 11:48   ` [PATCH 3/4] corpus: Handle empty symbol table cases Dodji Seketeli
2023-02-03 11:49   ` [PATCH 4/4] {dwarf,elf_based}-reader,writer: Avoid duplicating corpora in corpus_group Dodji Seketeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mt5vt3op.fsf@seketeli.org \
    --to=dodji@seketeli.org \
    --cc=dodji@redhat.com \
    --cc=gprocida@google.com \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).