* [PATCH] Improve documentation of abidiff --type-id-style
@ 2020-07-24 7:29 Giuliano Procida
2020-08-04 16:43 ` Dodji Seketeli
0 siblings, 1 reply; 2+ messages in thread
From: Giuliano Procida @ 2020-07-24 7:29 UTC (permalink / raw)
To: libabigail; +Cc: dodji, kernel-team, gprocida
* tools/abidw.cc (display_usage): In documentation of
"--type-id-style" option, add a missing closing ')', spell
"type id" without a '-', split overly long string over two
lines, use "<...>" to indicate mandatory argument and improve
description of formats.
* doc/manuals/abidw.rst: In documentation of "--type-id-style"
option, use "<...>" to indicate mandatory argument.
Signed-off-by: Giuliano Procida <gprocida@google.com>
---
doc/manuals/abidw.rst | 2 +-
tools/abidw.cc | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/doc/manuals/abidw.rst b/doc/manuals/abidw.rst
index 5834923b..d0720a0b 100644
--- a/doc/manuals/abidw.rst
+++ b/doc/manuals/abidw.rst
@@ -197,7 +197,7 @@ Options
1.8 will not set the default size and will interpret types without
a size-in-bits attribute as zero sized.
- * ``--type-id-style`` ( ``sequence`` | ``hash`` )
+ * ``--type-id-style`` <``sequence``|``hash``>
This option controls how types are idenfied in the generated XML
files. The default ``sequence`` style just numbers (with
diff --git a/tools/abidw.cc b/tools/abidw.cc
index 2cd848df..27a9e484 100644
--- a/tools/abidw.cc
+++ b/tools/abidw.cc
@@ -180,7 +180,8 @@ display_usage(const string& prog_name, ostream& out)
<< " --no-write-default-sizes do not emit pointer size when it equals"
" the default address size of the translation unit\n"
<< " --no-parameter-names do not show names of function parameters\n"
- << " --type-id-style (sequence|hash) type-id style (sequence(default): type-id-number; hash: hexdigits\n"
+ << " --type-id-style <sequence|hash> type id style (sequence(default): "
+ "\"type-id-\" + number; hash: hex-digits)\n"
<< " --check-alternate-debug-info <elf-path> check alternate debug info "
"of <elf-path>\n"
<< " --check-alternate-debug-info-base-name <elf-path> check alternate "
--
2.28.0.rc0.142.g3c755180ce-goog
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Improve documentation of abidiff --type-id-style
2020-07-24 7:29 [PATCH] Improve documentation of abidiff --type-id-style Giuliano Procida
@ 2020-08-04 16:43 ` Dodji Seketeli
0 siblings, 0 replies; 2+ messages in thread
From: Dodji Seketeli @ 2020-08-04 16:43 UTC (permalink / raw)
To: Giuliano Procida; +Cc: libabigail, kernel-team
Giuliano Procida <gprocida@google.com> a écrit:
> * tools/abidw.cc (display_usage): In documentation of
> "--type-id-style" option, add a missing closing ')', spell
> "type id" without a '-', split overly long string over two
> lines, use "<...>" to indicate mandatory argument and improve
> description of formats.
> * doc/manuals/abidw.rst: In documentation of "--type-id-style"
> option, use "<...>" to indicate mandatory argument.
>
> Signed-off-by: Giuliano Procida <gprocida@google.com>
Applied to master, thanks!
Cheers,
--
Dodji
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-04 16:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-24 7:29 [PATCH] Improve documentation of abidiff --type-id-style Giuliano Procida
2020-08-04 16:43 ` Dodji Seketeli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).