[Bug default/28783] New: Include libgen.h in tools/abisym.cc to support non-glibc systems

[Bug default/28783] New: Include libgen.h in tools/abisym.cc to support non-glibc systems

[dcantrell at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28783

            Bug ID: 28783
           Summary: Include libgen.h in tools/abisym.cc to support
                    non-glibc systems
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: dcantrell at redhat dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

Created attachment 13907
  --> https://sourceware.org/bugzilla/attachment.cgi?id=13907&action=edit
0001-Include-libgen.h-in-tools-abisym.cc-for-basename-3.patch

Ran in to this building and using libabigail on Alpine Linux, which is a
musl-based distribution.

I included libgen.h to pick up the basename(3) definition.  Musl provides the
POSIX basename(3) and not the GNU variant, but the usage in abisym.cc seems to
be within the scope of the POSIX basename(3).

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Re: [Bug default/28783] New: Include libgen.h in tools/abisym.cc to support non-glibc systems

[Dodji Seketeli]

Hello David,

dcantrell at redhat dot com via Libabigail <libabigail@sourceware.org> a
écrit:

[...]

> Created attachment 13907
>   --> https://sourceware.org/bugzilla/attachment.cgi?id=13907&action=edit
> 0001-Include-libgen.h-in-tools-abisym.cc-for-basename-3.patch

commit a37ee8f7da8d0b83ae4004269f71ea5b3c233e33
Author: David Cantrell <dcantrell@redhat.com>
Date:   Fri Jan 14 12:04:01 2022 -0500

    Include <libgen.h> in tools/abisym.cc for basename(3)
    
    Support building on non-glibc systems, such as musl, by including
    libgen.h for basename(3).
    
    Signed-off-by: David Cantrell <dcantrell@redhat.com>

Applied to master.

Thanks!

[...]

Cheers,

-- 
		Dodji

[Bug default/28783] Include libgen.h in tools/abisym.cc to support non-glibc systems

[dodji at seketeli dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28783

--- Comment #1 from dodji at seketeli dot org ---
Hello David,

dcantrell at redhat dot com via Libabigail <libabigail@sourceware.org> a
écrit:

[...]

> Created attachment 13907
>   --> https://sourceware.org/bugzilla/attachment.cgi?id=13907&action=edit
> 0001-Include-libgen.h-in-tools-abisym.cc-for-basename-3.patch

commit a37ee8f7da8d0b83ae4004269f71ea5b3c233e33
Author: David Cantrell <dcantrell@redhat.com>
Date:   Fri Jan 14 12:04:01 2022 -0500

    Include <libgen.h> in tools/abisym.cc for basename(3)

    Support building on non-glibc systems, such as musl, by including
    libgen.h for basename(3).

    Signed-off-by: David Cantrell <dcantrell@redhat.com>

Applied to master.

Thanks!

[...]

Cheers,

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/28783] Include libgen.h in tools/abisym.cc to support non-glibc systems

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28783

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from dodji at redhat dot com ---
patch applied to master.

-- 
You are receiving this mail because:
You are on the CC list for the bug.