Re: [PATCH v2, v4] XML reader: improve XML node traversal

[Dodji Seketeli <dodji@seketeli.org>]

Hello Giuliano,

Thanks for the your thourough response.

[...]

> And full disclosure, I've since found (a day or so ago) that the
> libxml Tree API already defines xmlFirstElementChild and
> xmlNextElementSibling which are essentially identical to the
> primitives I defined. This also gives me a boost in confidence that
> they are the right primitives for traversing the XML tree for
> libabigail.

Right.  As the text/element node handling issue is addressed by the
patch I sent, I went ahead and (hopefully) address the confusion and
useless redundancy that arise from not using the xmlFirstElementChild
and xmlNextElementSibling APIs.  I am thus adding two patches to that
one to use those functions instead.

[...]

> I was going to reply separately to review, but the commit below is
> quite short. I'm sure it addresses the issue of significant
> whitespace. If you haven't done so already, please test by removing
> all whitespace from all the test XML files and then running abidiff vs
> the originals. There is a short recipe for doing this in the bug
> report.

I have tested the series of 3 patches that I am going to post as reply
of this message with that script you added to the bug report at
https://sourceware.org/bugzilla/show_bug.cgi?id=27616.

There are two crashes that are unrelated to this issue at hand.  That's because
libabigail doesn't (yet) support comparing decls coming from templates
and that's a known issue.

The two invocations that crash are: 

build/tools/abidiff --harmless tests/data/test-read-write/test12.xml tests/data/test-read-write/test12.xml.wrung
build/tools/abidiff --harmless tests/data/test-read-write/test13.xml tests/data/test-read-write/test13.xml.wrung

Other than that, everything else seem to work.

Thank you for your time and dedication!

[...]

Cheers,

-- 
		Dodji